From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] usb: ulpi: Call of_node_put correctly
Date: Thu, 27 Jan 2022 11:25:02 -0500 [thread overview]
Message-ID: <90e32914-d66f-3ede-b104-454972b01ff2@seco.com> (raw)
In-Reply-To: <YfFG1gjpjAkiG64+@kroah.com>
On 1/26/22 8:04 AM, Greg Kroah-Hartman wrote:
> On Tue, Jan 25, 2022 at 11:53:58AM -0500, Sean Anderson wrote:
>> Hi Heikki,
>>
>> On 1/25/22 4:18 AM, Heikki Krogerus wrote:
>> > On Mon, Jan 24, 2022 at 12:33:44PM -0500, Sean Anderson wrote:
>> >> of_node_put should always be called on device nodes gotten from
>> >> of_get_*. Additionally, it should only be called after there are no
>> >> remaining users. To address the first issue, call of_node_put if later
>> >> steps in ulpi_register fail. To address the latter, call of_node_put
>> >> only after calling device_unregister.
>> >
>> > This looks like a fix, but you don't have the fix tag.
>>
>> You're right this should have
>>
>> Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT")
>
> Please resend this as 2 independent patches as they should not depend on
> each other, allowing this one to be backported, but the debugfs addition
> added only to 5.18-rc1.
The patches modify adjacent lines, so one will depend on the other. I
will order this patch first the next time.
--Sean
next prev parent reply other threads:[~2022-01-27 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:33 [PATCH v2 1/2] usb: ulpi: Add debugfs support Sean Anderson
2022-01-24 17:33 ` [PATCH v2 2/2] usb: ulpi: Call of_node_put correctly Sean Anderson
2022-01-25 9:18 ` Heikki Krogerus
2022-01-25 16:53 ` Sean Anderson
2022-01-25 17:01 ` Sean Anderson
2022-01-26 13:04 ` Greg Kroah-Hartman
2022-01-27 16:25 ` Sean Anderson [this message]
2022-01-26 13:37 ` Heikki Krogerus
2022-01-26 13:05 ` [PATCH v2 1/2] usb: ulpi: Add debugfs support Greg Kroah-Hartman
2022-01-27 16:31 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e32914-d66f-3ede-b104-454972b01ff2@seco.com \
--to=sean.anderson@seco.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).