From: Stefan Wahren <wahrenst@gmx.net>
To: Chen-Yu Tsai <wens@kernel.org>,
Markus Mayer <mmayer@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: brcmstb: enable hwmon
Date: Thu, 31 Oct 2019 14:08:36 +0100 [thread overview]
Message-ID: <91017889-2ae7-d467-eed3-6d3b2bb130b9@gmx.net> (raw)
In-Reply-To: <20191030163807.17817-1-wens@kernel.org>
Hi Chen-Yu,
Am 30.10.19 um 17:38 schrieb Chen-Yu Tsai:
> From: Chen-Yu Tsai <wens@csie.org>
>
> By defaul of-based thermal driver do not have hwmon entries registered.
>
> Do this explicitly so users can use standard hwmon interfaces and tools
> to read the temperature.
>
> This is based on similar changes for bcm2835_thermal in commit
> d56c19d07e0b ("thermal: bcm2835: enable hwmon explicitly").
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> This patch was only compile tested. A similar patch [1] was submitted to
> the downstream kernel, which I did build and actually run on a Raspberry
> Pi 4.
just a note: from my understanding [2] the brcmstb_thermal isn't the
right driver for BCM2711. Please consider the current downstream
solution for BCM2711 support as a quick hack to avoid writing a new
thermal driver. But must confess that i didn't test Florian's recent
changes yet.
Regards
Stefan
[2] -
https://github.com/raspberrypi/linux/issues/3101#issuecomment-527554223
>
> This one for mainline is much simpler, as it does not need to deal with
> the error path or device removal, due to the use of devres.
>
> [1] https://github.com/raspberrypi/linux/pull/3307
>
> ---
> drivers/thermal/broadcom/brcmstb_thermal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
next prev parent reply other threads:[~2019-10-31 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:38 [PATCH] thermal: brcmstb: enable hwmon Chen-Yu Tsai
2019-10-30 16:57 ` Florian Fainelli
2019-10-30 17:15 ` Florian Fainelli
2019-10-31 13:08 ` Stefan Wahren [this message]
2019-11-01 3:01 ` Florian Fainelli
2019-11-01 3:04 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91017889-2ae7-d467-eed3-6d3b2bb130b9@gmx.net \
--to=wahrenst@gmx.net \
--cc=amit.kucheria@verdurent.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).