From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 237ADC43461 for ; Mon, 14 Sep 2020 03:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9AC9208C7 for ; Mon, 14 Sep 2020 03:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726003AbgINDTB (ORCPT ); Sun, 13 Sep 2020 23:19:01 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12244 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725965AbgINDS6 (ORCPT ); Sun, 13 Sep 2020 23:18:58 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8AAEA707EE2375575932; Mon, 14 Sep 2020 11:18:55 +0800 (CST) Received: from [10.174.178.86] (10.174.178.86) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 14 Sep 2020 11:18:53 +0800 Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Muchun Song , Chris Down CC: , Johannes Weiner , , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , , LKML , Linux Memory Management List , kernel test robot References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> From: Zefan Li Message-ID: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> Date: Mon, 14 Sep 2020 11:18:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.86] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/14 11:10, Muchun Song wrote: > On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: >> >> Muchun Song writes: >>> In the cgroup v1, we have a numa_stat interface. This is useful for >>> providing visibility into the numa locality information within an >>> memcg since the pages are allowed to be allocated from any physical >>> node. One of the use cases is evaluating application performance by >>> combining this information with the application's CPU allocation. >>> But the cgroup v2 does not. So this patch adds the missing information. >>> >>> Signed-off-by: Muchun Song >>> Suggested-by: Shakeel Butt >>> Reported-by: kernel test robot >> >> This is a feature patch, why does this have LKP's Reported-by? > > In the v2 version, the kernel test robot reported a compiler error > on the powerpc architecture. So I added that. Thanks. > You should remove this reported-by, and then add v2->v3 changelog: ...original changelog... v3: - fixed something reported by test rebot