From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A460AC432BE for ; Thu, 2 Sep 2021 10:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 893A5610CF for ; Thu, 2 Sep 2021 10:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244634AbhIBKun (ORCPT ); Thu, 2 Sep 2021 06:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236263AbhIBKuj (ORCPT ); Thu, 2 Sep 2021 06:50:39 -0400 Received: from lb2-smtp-cloud9.xs4all.net (lb2-smtp-cloud9.xs4all.net [IPv6:2001:888:0:108::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFA7BC061575; Thu, 2 Sep 2021 03:49:40 -0700 (PDT) Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id LkHpmiwTclQKhLkHqmKOn7; Thu, 02 Sep 2021 12:49:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1630579778; bh=z8S8PBTuuy6W8YvwKgx9nMDnBhYR8E+ca6ZFT8GLcmg=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=SH0liSzmKgUoL0hI9UUZqzASA/gjwWlwQooMG9aktGrU1uGMgl84kJDu1NAguBx4V E9Eqv+9kC3J+R752P4lryn3ehBdGF4b3iJZb3uNRKpQbzvs9bG1MvnReYNPc//pwO6 5yI2iVZiwECDthkWxzdvnUZ37YUIOq86Arw7KwZo7WSc6DlWeQiEbk88gKYOfCqx6N gt5yQUfgnt/Z5Gz24FoIk8NWvWZif9R8id5qs+Q/PzJZkC2S6epM8ftzmOAfMR9pcA 93hraVwjiNjALm9m8IZS/NTHgMB0PUgkZHTr6g/aaj23VILwgkAbi7A+XKeXitIUEa uP9Yvei7/Iv/A== Subject: Re: [PATCH] media: usb: fix memory leak in stk_camera_probe To: Dongliang Mu , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel , Dan Carpenter , Greg KH References: <20210714032340.504836-1-mudongliangabcd@gmail.com> From: Hans Verkuil Message-ID: <911af8f1-d654-b4e1-1aac-c8a7ff94f6da@xs4all.nl> Date: Thu, 2 Sep 2021 12:49:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfMtG5773DVqMm00i2M9TjNm6lyyWSRkJZUlCS9i7Xgy8HAYiw1GYfZx9ltiiX9UpndCkRJZpsATVre9Rj9KHnQ+xJqm2KSm6t8edndVXEQxjhe06pbaV c5jNiYaiumt4ot483fjLZoxsDyrRbopSSalT8TY+0pWubTLpfWSAgKTGwqSM5/ccgmuiRFHuTrNRucYHkVTfVh5F5TNYquh0fuyIDhGTQdO5DEY+1TPhsKiJ HS4HP4/i7kjRiwaLlGX+ke4xgaLX65C6aPaRynUQkzA/3g3dCf0jNQbc+B0M716KKhFIGX+2pb+zM1STp6yrs7WcQiXvZznnT4K55USyyXl9BsEEjeHVEEj1 6hBJnR7sOn6sLQTuUMPV8oGVrPgj81+zckrVq4JLc/QxS99HVLhYdWxZe2s311N753y9WcWdjr3AhZEz1kSjnXFwf3MxUarvMPPNF3ICg/l77H19iRMQ8edy tEjWIISdJBFXd2jJ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dongliang, On 02/09/2021 12:23, Dongliang Mu wrote: > On Fri, Jul 23, 2021 at 6:11 PM Dongliang Mu wrote: >> >> On Wed, Jul 14, 2021 at 11:23 AM Dongliang Mu wrote: >>> >>> stk_camera_probe mistakenly execute usb_get_intf and increase the >>> refcount of interface->dev. >>> >>> Fix this by removing the execution of usb_get_intf. >> >> Any idea about this patch? > > +cc Dan Carpenter, gregkh > > There is no reply in this thread in one month. Can someone give some > feedback on this patch? I saw that it was marked as Obsoleted in patchwork, but I might have confused this patch with similar, but not identical, patches for this driver. I've moved the state back to New. Comments follow below: > >> >>> >>> Reported-by: Dongliang Mu >>> Fixes: 0aa77f6c2954 ("[media] move the remaining USB drivers to drivers/media/usb") >>> Signed-off-by: Dongliang Mu >>> --- >>> drivers/media/usb/stkwebcam/stk-webcam.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c >>> index a45d464427c4..5bd8e85b9452 100644 >>> --- a/drivers/media/usb/stkwebcam/stk-webcam.c >>> +++ b/drivers/media/usb/stkwebcam/stk-webcam.c >>> @@ -1311,7 +1311,6 @@ static int stk_camera_probe(struct usb_interface *interface, >>> >>> dev->udev = udev; >>> dev->interface = interface; >>> - usb_get_intf(interface); Even though this increments the refcount (which might well be unnecessary), it is also decremented with usb_put_intf. So is there actually a bug here? And if this is changed, then I expect that both get_intf and put_intf should be removed, and not just the get. Regards, Hans >>> >>> if (hflip != -1) >>> dev->vsettings.hflip = hflip; >>> -- >>> 2.25.1 >>>