From: Jan Harkes <jaharkes@cs.cmu.edu>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: coda@cs.cmu.edu, miklos@szeredi.hu, akpm@linux-foundation.org,
jgg@ziepe.ca
Subject: Re: [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path
Date: Thu, 22 Apr 2021 08:27:53 -0400 [thread overview]
Message-ID: <91292A4A-5F97-4FF8-ABAD-42392A0756B5@cs.cmu.edu> (raw)
In-Reply-To: <20210421132012.82354-1-christian.koenig@amd.com>
Looks good to me.
I'm also maintaining an out of tree coda module build that people sometimes use, which has workarounds for differences between the various kernel versions.
Do you have a reference to the corresponding mmap_region change? If it is merged already I'll probably be able to find it. Is this mmap_region change expected to be backported to any lts kernels?
Jan
On April 21, 2021 9:20:11 AM EDT, "Christian König" <ckoenig.leichtzumerken@gmail.com> wrote:
>mmap_region() now calls fput() on the vma->vm_file.
>
>So we need to drop the extra reference on the coda file instead of the
>host file.
>
>Signed-off-by: Christian König <christian.koenig@amd.com>
>Fixes: 1527f926fd04 ("mm: mmap: fix fput in error path v2")
>CC: stable@vger.kernel.org # 5.11+
>---
> fs/coda/file.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/fs/coda/file.c b/fs/coda/file.c
>index 128d63df5bfb..ef5ca22bfb3e 100644
>--- a/fs/coda/file.c
>+++ b/fs/coda/file.c
>@@ -175,10 +175,10 @@ coda_file_mmap(struct file *coda_file, struct
>vm_area_struct *vma)
> ret = call_mmap(vma->vm_file, vma);
>
> if (ret) {
>- /* if call_mmap fails, our caller will put coda_file so we
>- * should drop the reference to the host_file that we got.
>+ /* if call_mmap fails, our caller will put host_file so we
>+ * should drop the reference to the coda_file that we got.
> */
>- fput(host_file);
>+ fput(coda_file);
> kfree(cvm_ops);
> } else {
> /* here we add redirects for the open/close vm_operations */
next prev parent reply other threads:[~2021-04-22 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:20 [PATCH 1/2] coda: fix reference counting in coda_file_mmap error path Christian König
2021-04-21 13:20 ` [PATCH 2/2] ovl: fix reference counting in ovl_mmap " Christian König
2021-04-22 8:13 ` Daniel Vetter
2021-04-22 8:11 ` [PATCH 1/2] coda: fix reference counting in coda_file_mmap " Daniel Vetter
2021-04-22 12:27 ` Jan Harkes [this message]
2021-04-22 12:39 ` Christian König
2021-04-22 13:51 ` Jan Harkes
2021-04-23 8:10 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91292A4A-5F97-4FF8-ABAD-42392A0756B5@cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=akpm@linux-foundation.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=coda@cs.cmu.edu \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).