Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Gerhard Wiesinger]

Hello,

I'm having troubles with the Banana Pi-R1 router with newer kernels. No 
config changes, config works well since a lot of lernel updates ...
Banana Pi-R1 is configured via systemd-networkd and uses the DSA 
(Distributed Switch Architecture) with b53 switch. No visible difference 
in interfaces, vlan config, bridge config, etc. Looks like actual 
configuration in the switch in the hardware is broken.

# OK: Last good known version (booting that version is also ok)
Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020 
armv7l armv7l armv7l GNU/Linux

# NOK: no network
Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020 
armv7l armv7l armv7l GNU/Linux

# NOK: no network
Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020 
armv7l armv7l armv7l GNU/Linux

# NOK: no network
Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020 
armv7l armv7l armv7l GNU/Linux

# NOK: no network
Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020 
armv7l armv7l armv7l GNU/Linux


Saw that there were a lot of changes in the near past in the b53 driver:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+


Any ideas?

Thnx.

Ciao,
Gerhard

Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Florian Fainelli]

Hi,

On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
> Hello,
> 
> I'm having troubles with the Banana Pi-R1 router with newer kernels. No
> config changes, config works well since a lot of lernel updates ...
> Banana Pi-R1 is configured via systemd-networkd and uses the DSA
> (Distributed Switch Architecture) with b53 switch. No visible difference
> in interfaces, vlan config, bridge config, etc. Looks like actual
> configuration in the switch in the hardware is broken.

Can you share your network configuration again with me?

> 
> # OK: Last good known version (booting that version is also ok)
> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
> armv7l armv7l armv7l GNU/Linux

OK, I suspect what has changed is this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab

which, if I remember your configuration correctly means that you now
have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
can now run a proper networking stack unlike before where you had to do
this via the DSA master network device (eth0). This also means that you
should run your DHCP server/client on the bridge master network device now.

> 
> # NOK: no network
> Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020
> armv7l armv7l armv7l GNU/Linux
> 
> # NOK: no network
> Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020
> armv7l armv7l armv7l GNU/Linux
> 
> # NOK: no network
> Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020
> armv7l armv7l armv7l GNU/Linux
> 
> # NOK: no network
> Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020
> armv7l armv7l armv7l GNU/Linux
> 
> 
> Saw that there were a lot of changes in the near past in the b53 driver:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+
> 
> 
> 
> Any ideas?
> 
> Thnx.
> 
> Ciao,
> Gerhard
> 

-- 
Florian

Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Gerhard Wiesinger]

Hello Florian,

On 20.06.2020 21:13, Florian Fainelli wrote:
> Hi,
>
> On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
> Can you share your network configuration again with me? 

Find the network config below.


>> # OK: Last good known version (booting that version is also ok)
>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
> OK, I suspect what has changed is this commit:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
>
> which, if I remember your configuration correctly means that you now
> have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
> can now run a proper networking stack unlike before where you had to do
> this via the DSA master network device (eth0). This also means that you
> should run your DHCP server/client on the bridge master network device now.

Yes, config should be a proper DSA config, see also below. IP config is 
only on brlan and brwan.

Do the changes need a config change?
e.g. net: dsa: b53: Ensure the default VID is untagged
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6


Thnx.


Ciao,
Gerhard

Config:

brctl show
bridge name     bridge id               STP enabled     interfaces
brlan           8000.AAAAAAAAAAAA       no              lan.101
brlansw         8000.BBBBBBBBBBBB       no              lan1
                                                         lan2
                                                         lan3
                                                         lan4
brwan           8000.CCCCCCCCCCCC       no              wan.102
brwansw         8000.DDDDDDDDDDDD       no              wan

================================================================================

= /etc/systemd/network/30-autogen-eth0.network
================================================================================
[Match]
Name=eth0

[Network]
VLAN=lan.101
VLAN=wan.102
================================================================================
= /etc/systemd/network/40-autogen-lan.101.netdev
================================================================================
[NetDev]
Name=lan.101
Kind=vlan

[VLAN]
Id=101
================================================================================
= /etc/systemd/network/40-autogen-wan.102.netdev
================================================================================
[NetDev]
Name=wan.102
Kind=vlan

[VLAN]
Id=102
================================================================================
= /etc/systemd/network/50-autogen-brlan.netdev
================================================================================
[NetDev]
Name=brlan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brlansw.netdev
================================================================================
[NetDev]
Name=brlansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwan.netdev
================================================================================
[NetDev]
Name=brwan
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=false
STP=false
================================================================================
= /etc/systemd/network/50-autogen-brwansw.netdev
================================================================================
[NetDev]
Name=brwansw
Kind=bridge

[Bridge]
DefaultPVID=none
VLANFiltering=true
STP=false
================================================================================
= /etc/systemd/network/60-autogen-brlan-lan.101.network
================================================================================
[Match]
Name=lan.101

[Network]
Bridge=brlan
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan1.network
================================================================================
[Match]
Name=lan1

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan2.network
================================================================================
[Match]
Name=lan2

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan3.network
================================================================================
[Match]
Name=lan3

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brlansw-lan4.network
================================================================================
[Match]
Name=lan4

[Network]
Bridge=brlansw

[BridgeVLAN]
VLAN=101
EgressUntagged=101
PVID=101
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwansw
================================================================================
= /etc/systemd/network/60-autogen-brwansw-wan.network
================================================================================
[Match]
Name=wan

[Network]
Bridge=brwansw

[BridgeVLAN]
VLAN=102
EgressUntagged=102
PVID=102
================================================================================
= /etc/systemd/network/60-autogen-brwan-wan.102.network
================================================================================
[Match]
Name=wan.102

[Network]
Bridge=brwan
================================================================================
= /etc/systemd/network/61-autogen-brlan.network
================================================================================
[Match]
Name=brlan

[Network]
Address=192.168.39.2/24
Gateway=192.168.39.1
DNS=192.168.39.1
Domains=mydomain
================================================================================
= /etc/systemd/network/61-autogen-brwan.network
================================================================================
[Match]
Name=brwan

[Network]
Address=192.168.1.1/24

Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Florian Fainelli]

Le 2020-06-20 à 12:37, Gerhard Wiesinger a écrit :
> Hello Florian,
> 
> On 20.06.2020 21:13, Florian Fainelli wrote:
>> Hi,
>>
>> On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote:
>> Can you share your network configuration again with me? 
> 
> Find the network config below.
> 
> 
>>> # OK: Last good known version (booting that version is also ok)
>>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>>> armv7l armv7l armv7l GNU/Linux
>> OK, I suspect what has changed is this commit:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
>>
>>
>> which, if I remember your configuration correctly means that you now
>> have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces
>> can now run a proper networking stack unlike before where you had to do
>> this via the DSA master network device (eth0). This also means that you
>> should run your DHCP server/client on the bridge master network device
>> now.
> 
> Yes, config should be a proper DSA config, see also below. IP config is
> only on brlan and brwan.
> 
> Do the changes need a config change?
> e.g. net: dsa: b53: Ensure the default VID is untagged
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6
> 

No that change does not require a configuration change, the one I
mentioned does, you should only have a single bridge for all LAN ports
and no bridge for the WAN port and no VLAN is necessary since now that
Broadcom tags are enabled, Linux can properly determine which source and
destination port should be used.

Please try that and let me know how it goes.
-- 
Florian

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Peter Robinson]

> I'm having troubles with the Banana Pi-R1 router with newer kernels. No
> config changes, config works well since a lot of lernel updates ...
> Banana Pi-R1 is configured via systemd-networkd and uses the DSA
> (Distributed Switch Architecture) with b53 switch. No visible difference
> in interfaces, vlan config, bridge config, etc. Looks like actual
> configuration in the switch in the hardware is broken.
>
> # OK: Last good known version (booting that version is also ok)
> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
> armv7l armv7l armv7l GNU/Linux
>
> # NOK: no network
> Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020
> armv7l armv7l armv7l GNU/Linux
>
> # NOK: no network
> Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020
> armv7l armv7l armv7l GNU/Linux
>
> # NOK: no network
> Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020
> armv7l armv7l armv7l GNU/Linux
>
> # NOK: no network
> Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020
> armv7l armv7l armv7l GNU/Linux
>
>
> Saw that there were a lot of changes in the near past in the b53 driver:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+

So from your notes above it looks like something regressed between the
5.5.x series and the 5.6.0 release? If so I'm not sure what the
context of the changed in 5.8 are here. If there's more changes to the
driver in 5.8 dev cycle have you tried one of the Fedora rawhide 5.8
rc1 or rc2 kernel builds to see if that resolves it?

Failing that looking for the change in the 5.6 cycle would likely be
the better bet so we can work out what broke it and report it to the
upstream driver maintainer. Have you searched to see if others are
seeing a similar issue or have reported a similar issue upstream?

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Florian Fainelli]

On 6/25/2020 4:23 PM, Peter Robinson wrote:
>> I'm having troubles with the Banana Pi-R1 router with newer kernels. No
>> config changes, config works well since a lot of lernel updates ...
>> Banana Pi-R1 is configured via systemd-networkd and uses the DSA
>> (Distributed Switch Architecture) with b53 switch. No visible difference
>> in interfaces, vlan config, bridge config, etc. Looks like actual
>> configuration in the switch in the hardware is broken.
>>
>> # OK: Last good known version (booting that version is also ok)
>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
>>
>> # NOK: no network
>> Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
>>
>> # NOK: no network
>> Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
>>
>> # NOK: no network
>> Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
>>
>> # NOK: no network
>> Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020
>> armv7l armv7l armv7l GNU/Linux
>>
>>
>> Saw that there were a lot of changes in the near past in the b53 driver:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+
> 
> So from your notes above it looks like something regressed between the
> 5.5.x series and the 5.6.0 release? If so I'm not sure what the
> context of the changed in 5.8 are here. If there's more changes to the
> driver in 5.8 dev cycle have you tried one of the Fedora rawhide 5.8
> rc1 or rc2 kernel builds to see if that resolves it?

See my response to Gerhard, there are changes expected to how the
network configuration should be done after:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab

> 
> Failing that looking for the change in the 5.6 cycle would likely be
> the better bet so we can work out what broke it and report it to the
> upstream driver maintainer. Have you searched to see if others are
> seeing a similar issue or have reported a similar issue upstream?
> 

Gerhard is doing exactly this with his email.
-- 
Florian

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Peter Robinson]

On Fri, Jun 26, 2020 at 5:42 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>
>
> On 6/25/2020 4:23 PM, Peter Robinson wrote:
> >> I'm having troubles with the Banana Pi-R1 router with newer kernels. No
> >> config changes, config works well since a lot of lernel updates ...
> >> Banana Pi-R1 is configured via systemd-networkd and uses the DSA
> >> (Distributed Switch Architecture) with b53 switch. No visible difference
> >> in interfaces, vlan config, bridge config, etc. Looks like actual
> >> configuration in the switch in the hardware is broken.
> >>
> >> # OK: Last good known version (booting that version is also ok)
> >> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
> >> armv7l armv7l armv7l GNU/Linux
> >>
> >> # NOK: no network
> >> Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020
> >> armv7l armv7l armv7l GNU/Linux
> >>
> >> # NOK: no network
> >> Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020
> >> armv7l armv7l armv7l GNU/Linux
> >>
> >> # NOK: no network
> >> Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020
> >> armv7l armv7l armv7l GNU/Linux
> >>
> >> # NOK: no network
> >> Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020
> >> armv7l armv7l armv7l GNU/Linux
> >>
> >>
> >> Saw that there were a lot of changes in the near past in the b53 driver:
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+
> >
> > So from your notes above it looks like something regressed between the
> > 5.5.x series and the 5.6.0 release? If so I'm not sure what the
> > context of the changed in 5.8 are here. If there's more changes to the
> > driver in 5.8 dev cycle have you tried one of the Fedora rawhide 5.8
> > rc1 or rc2 kernel builds to see if that resolves it?
>
> See my response to Gerhard, there are changes expected to how the
> network configuration should be done after:

It appears your response was off list, and he had follow up questions
and I don't see a response from you.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
>
> >
> > Failing that looking for the change in the 5.6 cycle would likely be
> > the better bet so we can work out what broke it and report it to the
> > upstream driver maintainer. Have you searched to see if others are
> > seeing a similar issue or have reported a similar issue upstream?
> >
>
> Gerhard is doing exactly this with his email.

No, I asked if he'd searched elsewhere to see if others are having
problems, like other distros etc.

Re: [fedora-arm] Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA

[Florian Fainelli]

On 6/26/2020 2:09 AM, Peter Robinson wrote:
> On Fri, Jun 26, 2020 at 5:42 AM Florian Fainelli <f.fainelli@gmail.com> wrote:
>>
>>
>>
>> On 6/25/2020 4:23 PM, Peter Robinson wrote:
>>>> I'm having troubles with the Banana Pi-R1 router with newer kernels. No
>>>> config changes, config works well since a lot of lernel updates ...
>>>> Banana Pi-R1 is configured via systemd-networkd and uses the DSA
>>>> (Distributed Switch Architecture) with b53 switch. No visible difference
>>>> in interfaces, vlan config, bridge config, etc. Looks like actual
>>>> configuration in the switch in the hardware is broken.
>>>>
>>>> # OK: Last good known version (booting that version is also ok)
>>>> Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020
>>>> armv7l armv7l armv7l GNU/Linux
>>>>
>>>> # NOK: no network
>>>> Linux bpi 5.6.8-200.fc31.armv7hl #1 SMP Wed Apr 29 19:05:06 UTC 2020
>>>> armv7l armv7l armv7l GNU/Linux
>>>>
>>>> # NOK: no network
>>>> Linux bpi 5.6.0-300.fc32.armv7hl #1 SMP Mon Mar 30 16:37:50 UTC 2020
>>>> armv7l armv7l armv7l GNU/Linux
>>>>
>>>> # NOK: no network
>>>> Linux bpi 5.6.19-200.fc31.armv7hl #1 SMP Wed Jun 17 17:10:22 UTC 2020
>>>> armv7l armv7l armv7l GNU/Linux
>>>>
>>>> # NOK: no network
>>>> Linux bpi 5.7.4-200.fc32.armv7hl #1 SMP Fri Jun 19 00:52:22 UTC 2020
>>>> armv7l armv7l armv7l GNU/Linux
>>>>
>>>>
>>>> Saw that there were a lot of changes in the near past in the b53 driver:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/net/dsa/b53?h=v5.8-rc1+
>>>
>>> So from your notes above it looks like something regressed between the
>>> 5.5.x series and the 5.6.0 release? If so I'm not sure what the
>>> context of the changed in 5.8 are here. If there's more changes to the
>>> driver in 5.8 dev cycle have you tried one of the Fedora rawhide 5.8
>>> rc1 or rc2 kernel builds to see if that resolves it?
>>
>> See my response to Gerhard, there are changes expected to how the
>> network configuration should be done after:
> 
> It appears your response was off list, and he had follow up questions
> and I don't see a response from you.

Off which list? My response copied all the To and CC list from the
original email:

https://lore.kernel.org/lkml/002b144c-3e71-4418-3a6b-ee17c2ce6b38@gmail.com/raw

(except Maxime's old email which now bounces).

and I have not seen a response for that email.
-- 
Florian