From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521EDC5ACAE for ; Wed, 11 Sep 2019 22:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27EE12081B for ; Wed, 11 Sep 2019 22:11:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="QVCVJyaz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728921AbfIKWLf (ORCPT ); Wed, 11 Sep 2019 18:11:35 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39825 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbfIKWLf (ORCPT ); Wed, 11 Sep 2019 18:11:35 -0400 Received: by mail-pf1-f196.google.com with SMTP id i1so5727895pfa.6 for ; Wed, 11 Sep 2019 15:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q6jLEHDrdAVkyK20fWjT39oclCB9S4iV/KFrjMBbJeE=; b=QVCVJyazN/1N3tJh29TNpXnPZfFboklNshuMEVATsFL73C4lZ3qdC9cIJwoWXu03no Yo+usfFGucs6trZ6+x8CKnsjWG1J93b4JdVgkzYxMZtJjlsmh6pRNhFufp6iwRTUeiZT MdmwZDKL3OJ4enBbnJjaALuEsrl8rx30ORRFnv2Jr+pCyQKgT/0b2/WOfiaT1DVa87G5 Y2NPh7gy9tsZ00Phml674zGM20dJ/8cuZjGJDzYAsjA9Z6pGr2jo2reiYecdjUlWGfd6 JNDirCjdVZwZUzGsqb5fF0iFPnLZXl4Rrnd4IZtgZ2f8Ofom94jQ2//HypL5e60Iw0+s WHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q6jLEHDrdAVkyK20fWjT39oclCB9S4iV/KFrjMBbJeE=; b=rCpFSPlGUSnNG7walunhCa7Lb/IB9FF/J8RBK2UWB3XNe6g40818+ewTKE3DltlXrY 66RbO7hVSgxqNl2AayZyih6NsaBe94TtifLwBcWFuduh4WIM1zH+Vzm+6Z4qCWoBjQpn hSx3N6yxB84b3P/yEflEKMZa51zm1RukIFIT5YbMRG5MKUYYx8B19SS9wojfyRHPFkzO rPYZX54QTew52l5QUj6XMt5gwQ8f84XIVp83EcqWqVh9dQmW4balUXYWcPShvYN7/n8Z QSMHZpwx7B0jIhrIg4hp5B7qdDqmzofDswupDgmE39RVcF345MNz4EjhHGSIeGTi6msz /qgQ== X-Gm-Message-State: APjAAAWBkmdZAzzgE2uA2swRuPCRiFzB5tXsaFOacqnEf3Va0RUigEJT F5GPaMs0uwLI2lhGFVLM/bHk/g== X-Google-Smtp-Source: APXvYqzc+AsW4ZOIn8LcwEkNbf6geCnMtHj/uM/luJQFVU08Hw7GR90DEjIbBO8Yfy27zfgzGqT8Rg== X-Received: by 2002:a17:90a:fa3:: with SMTP id 32mr8129966pjz.35.1568239892801; Wed, 11 Sep 2019 15:11:32 -0700 (PDT) Received: from [192.168.1.188] ([23.158.160.160]) by smtp.gmail.com with ESMTPSA id q4sm24322182pfh.115.2019.09.11.15.11.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2019 15:11:31 -0700 (PDT) Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile To: Dan Carpenter , Dan Williams Cc: Dave Jiang , ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm@lists.01.org, Vishal Verma , linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com> <20190911184332.GL20699@kadam> From: Jens Axboe Message-ID: <9132e214-9b57-07dc-7ee2-f6bc52e960c5@kernel.dk> Date: Wed, 11 Sep 2019 16:11:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190911184332.GL20699@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/19 12:43 PM, Dan Carpenter wrote: > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: >> +Coding Style Addendum >> +--------------------- >> +libnvdimm expects multi-line statements to be double indented. I.e. >> + >> + if (x... >> + && ...y) { > > That looks horrible and it causes a checkpatch warning. :( Why not > do it the same way that everyone else does it. > > if (blah_blah_x && <-- && has to be on the first line for checkpatch > blah_blah_y) { <-- [tab][space][space][space][space]blah > > Now all the conditions are aligned visually which makes it readable. > They aren't aligned with the indent block so it's easy to tell the > inside from the if condition. > > I kind of hate all this extra documentation because now everyone thinks > they can invent new hoops to jump through. FWIW, I completely agree with Dan (Carpenter) here. I absolutely dislike having these kinds of files, and with subsystems imposing weird restrictions on style (like the quoted example, yuck). Additionally, it would seem saner to standardize rules around when code is expected to hit the maintainers hands for kernel releases. Both yours and Martins deals with that, there really shouldn't be the need to have this specified in detail per sub-system. -- Jens Axboe