From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934540AbcI2Rno (ORCPT ); Thu, 29 Sep 2016 13:43:44 -0400 Received: from mail-sn1nam02on0043.outbound.protection.outlook.com ([104.47.36.43]:1980 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934123AbcI2Rnf (ORCPT ); Thu, 29 Sep 2016 13:43:35 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct To: Alan Tull , Moritz Fischer References: <20160928182200.15800-1-atull@opensource.altera.com> <20160928182200.15800-6-atull@opensource.altera.com> CC: Alan Tull , Rob Herring , Frank Rowand , Mark Rutland , Greg Kroah-Hartman , Ian Campbell , Jon Masters , "Walter Goossens" , Michal Simek , Cyril Chemparathy , Josh Cartwright , Matthew Gerlach , Dinh Nguyen , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List From: Michal Simek Message-ID: <914ed9fb-c219-d034-7a5e-a400b80dfee0@xilinx.com> Date: Thu, 29 Sep 2016 10:43:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22606.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(377454003)(189002)(24454002)(81166006)(50466002)(81156014)(83506001)(189998001)(63266004)(23676002)(76176999)(626004)(9786002)(19580395003)(19580405001)(92566002)(87936001)(65956001)(50986999)(106466001)(11100500001)(4326007)(31686004)(8676002)(230700001)(77096005)(33646002)(2950100002)(586003)(65806001)(5001770100001)(36756003)(7846002)(2906002)(47776003)(4001350100001)(54356999)(5660300001)(8936002)(36386004)(7416002)(356003)(86362001)(305945005)(31696002)(65826007)(64126003)(93886004)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR02MB2886;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1NAM02FT027;1:Y8nQ/cVStxU0ezG6z6McAleWawawmEEQ3rsKqGG3qFEVABR6/g39bByl2FvkE8rYD/gIHBFDP/qgpriTE6dWmam3UYNcb+NeS2wjaOIYGzFW7doZLqfMIur8ki1h+YgKgkih7AGnzZyoYwWz15YHySkWZ9vvROZV2H4o8CgT3Do7twzzlIX+ZrtuvXgTRnWYe6uf4f3LY6fcMYJRwCPirSBtcfyasFpPDKSSMvJIzBdLzwu/DHrbigCUODwxp99MkIyr2SWBdE31zxDhoY7NX3Ic3Tj4smhHGZ4FHuTPioiLbWTQeD5G8fPqhGWmiJZM3CzVsF30yBluJGuUcJ7N+UgrTkS464c3eJGws5vwb4QPRu2En6LpTKEU/9uKLPaXlxXAMq5KGYzZO3jlb+K7oDq5SqEq+86NZMKNVuzWc2IdxQAtKfCWN4e+qU2//LIiiDH74pWi3jjQ9aewsqfwweS6sYB7Q+bXENMLvgHVQhEfLOQIHNUQykF4ZuVAZ7NI18AhYxG+6GfL4ssMwcQyCLr281TNghb+Slmxty/0QTas+Zey6PVZcdwSb8cEnx4OauEVxkx57CHw7ZHFCZvR35GFSHZ3cyMBQpJ3rIPL8rA= X-MS-Office365-Filtering-Correlation-Id: 0adddc5b-b5b6-41e4-0817-08d3e89020c5 X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2886;2:JNjlQxZYDZBY2RIlm+iBDB79Wi7e7x+00zDg8l4YMrLQUa4QNrKGBsvI3nZdsTsnUvyYFDav4l8SXXNritMKHZqAQqCrNnwWB/tGg25Z9nE1Om6O0cOZhqMOJjjF3cLescY1DXMxj+f3nbIPqb09QrCYUoQpGvvF5cJ7c2UE2mR2aBDlN3dO8ktnG449BYTp;3:z0xA6QumjgZXZkAMSqLgMRjUX1d6h9L1wwL0vHLeW5VkFyTuN+P33vUKHFbAKGM4+4uAtO9TtAwXWqsfgvRDpLzPRrfvH28YmTC/g9//WRjU8jCkbUJz5qXyPtUeqnhQZSXKc5ZNWq9LXIPlicxbFcY5ht31hD/VHmW7xELxz/YWoIN4WWENkC0KxosDyx/M09AA+qaaLskWAX9+X3n41V9z3tevBa0Uk1mTRwe0B9/oMSDuptWPR0dzQSiEnCa14Z3RjEjYFU8Ux7U+ePWThQ==;25:+gKPgunpUImg8P/qdAO9VVUJofQtrNLKDH3DYSJMG8M40eL7lgJ4wBCPRs4jOXIGY4f2yrnRGb8D8BYFnpWtwxuZJBB0cOn/+xTUy8mZQM7trvn4niv1+x1Opa/HY0zHWjLnjbZU+vdhW7a8BO+NVRSUGXnuPn8bFfmmBO9s8PxH8e73cpwW57XAWu9DDADspigeasTzTsr8IiP1qkw3sxxq1VhYV1WIqm6ouxrURtlwlkpX3c+SoR9Y57+76Q++kkUN0CQ4un+O6oEi5lMmmENVhbtDFpNS0cAl6mIRV7YK6IJuOOGB2P5uv7LHPWpJZPdAiJC8Xe19cu/nuQIYtA2zbT3DerShrTIPbFhoAy+1IFLAF//UKhuTjbwl4Xq19tzvieJ6gm5gx9FnNytSUqmNYCyxilLIt1b+Yv8wVss= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY4PR02MB2886; X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2886;31:IDaSO6arhksodrromYiFDSiLN/f3lE+9vJVvc7kD9C91IELJ7g1Nf1/n6j1prIiPToNldXlgoKb7fgGHxATQmXQv3vVQAC0JPemrf9hg8cqoIY3lKiclg+jIubqwUIj+C6ZNFnmqKvmCn+3LmPyeQK4oPGjSa+fbxQjD6dXYnESFfd1GbOxMuXF/NAdBX2QZfUl3yuTOE9siXKLJzIbYJNlv9/+zNSE/unUIj6tWx0E=;20:ApfAy297xVff4ayy8G+mUA09IPL62X9zz0l91F15f3GruGA53qDZgK+/a7QYIXhvgsSZeCgS+1FTBUfomyHLxeAxMBbFFMToPP+gEmRfBuiVAAAdImbwEL+Bkmg059jLRw+cBtWs9BMVeQ7dq58L8oUHZoKsgg2bga+WCYcG27WhUSL2B70wycsT7pCxv9wc0v9TuarDTMN0Z8N6rTA6+n7jQjEqsLVPcHLYYKuUamFSIe3VkkHy8HuNECqVx6PIvENjZ9rUSLST2v8nBsXQ7WE9bWqk/ZiIN8+by4m0HGk6YHqAtaSuSnw3bImCa2G8cMq4h6T8rJUwzm7HNWnWPLLerEa1oGuGs5lz6JmDU8q7ZRuxYGXwCw7jurYcBhUim5GvjPXbrnBPKyt4QezvoWmWSudJojyVmpQLZaJxnD6RAP2PK3zqnGAXNonK8mKq9aX2tkQ5PdLxsG5kgLlOLRYXGqO1GRw1iqbNdtf8ti9wfTFgStjwMZqc6jZoPJfj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(13017025)(13023025)(13018025)(13024025)(13015025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:CY4PR02MB2886;BCL:0;PCL:0;RULEID:;SRVR:CY4PR02MB2886; X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2886;4:uP3t+4dClVOw1tEgxmkccieD3PuNl68HiDRxRrQgJ0yVh0tGRPS/Z96kxm5RkI+DZcPu9oVL+aznhsrWivsCAIqKnMN1+RhP9bBgYBywHIJffbmg8dcelM7HwsMjnOoKY+S+f0YopBdbIe6/MhpQgFpfuTWxU5JMXU/F7QHI/1XseKQljoME7CHiGsxepJo7RMNJ8IVKcZlcAAK6jiCIOKcCjqYMQ2aECaWOizhY+gv4gSFKw8spthrDL5CWuPM75kHaJY5gf5yF+wUeKYcwKMfdkDaOF42D4jMAkvz8OnSqb7C+DhKqVoNmqpZy5O7YjXqUg0Hhm5Wzu3xmRH25NsuTBrqyvwD4Tx4rDIqFelOVEr7Ql0rRplMYAGXiS+s2CMV6W5zOLYnB1utx7Qdqd9LbrFWMOoFPM4jtcd8TQF7iQ+h5l1JzUe4bjZhasS+rQl5OoEMimUS7V3AjHhBK9iiGKfhhwu5eNlW8hmw7nSL32b1N3e1fp74ElM+74Fj3yKTtsrA/BhaV1kJZj+0H1cnpXZM2FDRGFX62fHSms88= X-Forefront-PRVS: 00808B16F3 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAyTUIyODg2OzIzOk5vSWg3cW1SUVN1QkYvSVYrbU8wY3NIa2lm?= =?utf-8?B?bEpDZEU1NDZjK1EyTjRoQUZ3SEFEZjVSYnVqbGdLb0VhemE5OXp4OHRCV2s0?= =?utf-8?B?NHh6WHdNYU9vUTdnWWQ4WkVoVXVTMGxNNlVDZE0ydk9FcmdDQ2R3MlVIMlNN?= =?utf-8?B?Z1ZvMFBrcjVYOE5tdmJNaDBFUXUxbVZiOWdtc2lwWU5xVnJZKzhLMWkvbGo2?= =?utf-8?B?WHEvQWNZeHdxRGptT2ZNTElTZ1dPN2pyZC96RmdxRE1tejRLZkhpaERNSGV2?= =?utf-8?B?eEcrbnpyNW9jaWVxQ05kcWxBakVMY1d0VDdsZkJ1bkZhRU56VDcrc3BOTXN6?= =?utf-8?B?RS8zbnBMUEU0ckpTcGFRRVpCSnk5SFdGMDlEeHcwdGh0VzZZNEtZallWRTcy?= =?utf-8?B?cjBUdXUzT3ZQRHVYRy9YR2VJc0RISm1nUi9KMkhBajI1MmhPdGFYQTNGZUU3?= =?utf-8?B?RVhYcGs0ZHp4eHJjUjV5ZmR2ZGdRcUEraEJWNFZ2SWt1UWt0azdCQlU2VU9t?= =?utf-8?B?cm1QbTlieXViQk5OYmEwUEdMSHV3Yk9FeDBoYlpKK2o2NUNRejgvbVNNTkVD?= =?utf-8?B?TUsvQVFyV0FzTnMwZlVWNXpPS1J6RFJ1VVFkRGR6Vy9UWjZhSmJnOENITXA0?= =?utf-8?B?MUdaYWIvWHVNakNDdXYzT2FzZUpJTURweml6bWhUVWVsbkdWTkhzcTlUZDFH?= =?utf-8?B?b3pKUjFZeExMeHgzK0pWMzM1QjBsOXVxWEhPV2NmOW9pMG11UEdSc0RLOENX?= =?utf-8?B?VmkwQ0JYRFpnTFZTZDNiZ1pCanUwTStqZVM3K2pvUi9sd0RySnVrWnRJR3hp?= =?utf-8?B?cTFpc1NYOFM3NUg3UHd3MGRzTEV3ekVPUE9LdXNTekNzMFFQZVJpVm1Ncm00?= =?utf-8?B?dTZTa0VWdUx3aThteGlUcllLRkZ3ZWI4S2wxVTFBaGRlRUo0UU41R0NDbVQ0?= =?utf-8?B?TnRaTVZxUXdUUDMwVHFaZ3JmRXdBb0wxZGtsQ0pHQklzcURmUmRMckkzVk5U?= =?utf-8?B?TDZMUmNRWUJ4NXh4UjJueThxQVN5cnphejQrTVhEVjZmcy9GZ3BPZlcrZGpl?= =?utf-8?B?YXVETTRNZEFjQk41V1BiL2lIRFhxRGN4NytMSzREc3Q3Nm4yK1F1OSs2WE9R?= =?utf-8?B?OW1FKzVJRjlYMHhRQWtydHVYdTRId2VqdzBGQXZYSW5qTXlqRHpkZzQ3Nit2?= =?utf-8?B?TDB3L3p6V09wd2IvTm1mZEVuNGI0bDdnL0NIc1Q1dXlxdmpNV2tHSVk2ZHk1?= =?utf-8?B?a3NZYlBMdlhjNno5WURzTnR6eWIya25mY0srV29WYXRVeVdDLzZ3STZITlBr?= =?utf-8?B?MTBRa25MdHRqK3lEdU9LSEw2RThiWHlYaHkyZy9reFR0ODcvdzZ2MUw1SmY0?= =?utf-8?B?cGNtRGxDNG42NFFwS1ZmaWVCTUQrZjJNaHZYNGczTXV2TnR5ZHpReGZQSWJk?= =?utf-8?B?U0Npa2Z2bEFLS1Bma2krVGM3ZFp3YzA4Q05xdk9QM0dsbHpjNlJ4N0hQbzlj?= =?utf-8?B?dU9KcjRYVnV1azlLZkx6YytlVU5TZ05RYnJYbGlrOFJ6M0VJaURKQ2tWOCtZ?= =?utf-8?B?VlZFOGdHUzBYbFpWYlRMOTNvRGZpcE9JckxEWVNRZmNrM0JTcUFNekV1bUVz?= =?utf-8?B?VEhIcStucHZBM1J0NXRjNnJmOU5ucElxVXBLdSs4cFBITDFveXRoenRNMXIw?= =?utf-8?B?SWxDUGhLcE9ZWlBoMnBySGZhWURtdEtodUNBYWhDZXkvcEVWVlJKT1hCOVMv?= =?utf-8?B?djJIWUR2dEkzRC9XaGV4ZHlRdit3L3gvc1MrRU1aa2tyWkozVzZzUXV4cXFI?= =?utf-8?Q?L4+x8hxTpz28e?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR02MB2886;6:VFg8IBb3Ku6lO7KzITnkWNswRxjiDxkVFu/3jEgd0fE2ATyli49g3cuqEB5+3HSH9ZoqNaaRjVqCC+ONO2zrGadyPdnnAPYF9BXKoQ3SBnstZe1eqN8YNrCK6zHZRf2RlDiU+2WJDtQraYMqZC3VBgqdhpqo3DFvebfiyz3OHd0TJCjEpWfV6iMHAN1Zb+9MH7aAhoErsvCRxOX6X4rt7qrgzB1PxqBcJx0XZJyiCE/7m6FaH/2EpB7ar8ZOhkx+TzXL2lvqqMpHyhwY6FJB8kQE9nbw4UYzrfj2aUfamM5t0SFkirH31Yb+QqH/vA5Yzv9ZUMgEogHRvbFKZxUrFQ==;5:KG6Xz2PHaAKGIKNEeceI89jqxSlYdKXbUDr5udoILSAkE/HzR7a9eEREuydP2d3iJRxn77RAKFueYTaVPloMFWLmS0qq9Hcd+OOrjme0L82yPRPK4BCo6b5+gdFkw80j/a9nGmt8dqGB1en6SiqLOA==;24:zhrATBwH3ayOntSlcFBU7e1xe78LsNHr/FcDIpwTL5671FfbG4FrAwP5hedsHWcEBXTTQxjzrCiHfLZunF9xI+I5S61BG9ECFzscxvMIp08=;7:pi+HSn6kOpVKGoJ3dcgKtjivzhxiF5JFzDbD7UsdEhNxshH9JH+PB6gnRa+Pvu/W6WWXFSgM60FVqcoSeWog0XKLjj+XPheWjysRmLBUSxcBNhz1f50oXkag/vTEZzG5RcO8L/PwgtuMku6voi8ZPiavWB0IPA8EuF5gK0Ak71BSVp/43wjyPhcP7F7uZ66ln7WkICnZMYCBAn38sZ8CUxoeSb8jX8+AJc/a/pVhjSKkM5iE/Ae1m9cTlYpLg2k+HuIdaYZuU9tDMMjqbU1Xu73vYYP4ytp1jpQ/h/2tGHsRe2ZrmW+VV70xPKvO1vHc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2016 17:43:25.3495 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2886 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.9.2016 21:34, Alan Tull wrote: > On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer > wrote: > Hi Moritz, > >> Hi Alan, >> >> generally ok with the change. > > Cool! > >> >> On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull wrote: >> >>> -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, >>> - size_t count) >>> +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info, >>> + const char *buf, size_t count) >> >> Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are >> not part of this commit? >> i.e shouldn't 5,6 and 7 be a single commit? > > Yeah, squashing those would improve bisectability. Improve? :-) Definitely this needs to be the part of this commit. M