From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<swboyd@chromium.org>, <quic_collinsd@quicinc.com>,
<quic_subbaram@quicinc.com>, <quic_jprakash@quicinc.com>
Subject: Re: [PATCH V14 8/9] arm64: dts: qcom: pm8008: Add base dts file
Date: Thu, 9 Jun 2022 10:54:52 +0530 [thread overview]
Message-ID: <915be92d-302a-9149-a525-a375146a3fd9@quicinc.com> (raw)
In-Reply-To: <CKJXIE08RHD0.31NM2AKTA8B9V@otso>
Hi Luca,
On 6/7/2022 6:46 PM, Luca Weiss wrote:
> Hi Satya,
>
> On Tue Jun 7, 2022 at 1:50 PM CEST, Satya Priya wrote:
>> Add base DTS file for pm8008.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> Changes in V14:
>> - None.
>>
>> Changes in V13:
>> - None.
>>
>> Changes in V12:
>> - None.
>>
>> Changes in V11:
>> - Remove intermediate regulators node and add the ldos under
>> pm8008@8 node.
>> - change the address cells as 2 for pm8008 parent mfd node.
>> - add compatible to register the ldos.
>> - add reg with i2c client offset and address.
>>
>> arc
>> arch/arm64/boot/dts/qcom/pm8008.dtsi | 54 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> new file mode 100644
>> index 0000000..6f37e4d
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> @@ -0,0 +1,54 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +// Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> I noticed this file was licensed as BSD-3-Clause in V13 and
> this change was not mentioned in the "Changes" part.
> Any specific reason? Especially newer dts files should be BSD-licensed,
> and having this GPL dtsi included in otherwise BSD dts files is not
> good.
I changed it as per the suggestions of Qualcomm internal review team but
i see that many of the drivers use BSD license, will change this back to
BSD-3-Clause.
> Regards
> Luca
next prev parent reply other threads:[~2022-06-09 5:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 11:50 [PATCH V14 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-06-07 11:50 ` [PATCH V14 1/9] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-06-07 11:50 ` [PATCH V14 2/9] dt-bindings: mfd: pm8008: Change the address cells Satya Priya
2022-06-07 11:50 ` [PATCH V14 3/9] dt-bindings: mfd: pm8008: Add regulators for pm8008 Satya Priya
2022-06-07 11:50 ` [PATCH V14 4/9] mfd: pm8008: Add reset-gpios Satya Priya
2022-06-07 11:50 ` [PATCH V14 5/9] mfd: pm8008: Remove the regmap member from pm8008_data struct Satya Priya
2022-06-07 11:50 ` [PATCH V14 6/9] mfd: pm8008: Use i2c_new_dummy_device() API Satya Priya
2022-06-07 11:50 ` [PATCH V14 7/9] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-06-08 1:39 ` kernel test robot
2022-06-08 19:42 ` Stephen Boyd
2022-06-09 5:20 ` Satya Priya Kakitapalli (Temp)
2022-06-10 20:45 ` Stephen Boyd
2022-06-07 11:50 ` [PATCH V14 8/9] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-06-07 13:16 ` Luca Weiss
2022-06-09 5:24 ` Satya Priya Kakitapalli (Temp) [this message]
2022-06-07 11:50 ` [PATCH V14 9/9] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=915be92d-302a-9149-a525-a375146a3fd9@quicinc.com \
--to=quic_c_skakit@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).