From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755847AbdLVI3q (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Dec 2017 03:29:46 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:35446 "EHLO
        mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753654AbdLVI3n (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Dec 2017 03:29:43 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171222082940euoutp011afbdaa392ae4cfded150b1c03e55323~CkJHeH7zD0526405264euoutp01C
X-AuditID: cbfec7f5-f79d06d0000031c7-05-5a3cc273827c
MIME-version: 1.0
Content-type: text/plain; charset="utf-8"; format="flowed"
Subject: Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG
 driver
To: Herbert Xu <herbert@gondor.apana.org.au>,
        =?UTF-8?Q?=c5=81ukasz_Stelmach?= <l.stelmach@samsung.com>
Cc: "Andrew F . Davis" <afd@ti.com>,
        PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Matt Mackall <mpm@selenic.com>,
        Krzysztof Kozlowski <krzk@kernel.org>, Kukjin Kim <kgene@kernel.org>,
        devicetree@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
From: Marek Szyprowski <m.szyprowski@samsung.com>
Message-id: <916163bb-594b-779d-700c-de9fa15239dd@samsung.com>
Date: Fri, 22 Dec 2017 09:29:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
        Thunderbird/52.5.0
In-reply-to: <20171222082412.GB29663@gondor.apana.org.au>
Content-transfer-encoding: 8bit
Content-language: en-US
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXfOdo6rE6c586E7Cz900QqyTqvEIuJ8ifxYItTQ01w5lR2N
        DIJlzUpjVitahy52MUzJ6Zgriy3d1LWKabouK5qW2kiRJAu6Sm5nwb793v/zPO//ff68JKbo
        ks4ndcVlnKFYU6SSyXFnz89AOu/ZnLvm+ssNzJen5wim1WqTMte7AlKmZmwhUzs8jjG9vS0E
        E/I0IGYw/FPCDDy8ImOsvW4JU+c0I6a+1ocYk6uLyKbYduE9wTo70lh742kZa3Y0Itb8uQWx
        vjf3JeyUfXEOkSvfXMAV6Q5xhtVZ++SFfkHAS28Sh71n3smMyCqrRkkk0OvgcrAZE3ke9IVt
        M7qcVND1COyuS5h4mELgDQozFTI2Mfxov6jfQfDEcVEanaboufDDEsajjNFq+DRtkopNEQS/
        LwRjhWQ6B+61jRNRVtI6MIcq8WgTRt/A4KtjMvYOGb0WqieqZeKtWfAmZJVEGafT4KrQFnNL
        ofNgpG8IRTmJ3ghDPR/izkugMxiJcyocN4ViBkDXEPDn1luJuOh2MD/pxEVOhjGfgxB5IQxY
        auJ6LYJK00qRrQgCE5TIm8DreyEVDebAeWc0o2gsFJyqUogtLPy9eCx+zVZ4/PByPMZJBCPd
        14izaImQkJiQkJiQsIOQsEMdwhuRkivn9VqOz8zgNXq+vFibkV+it6OZv/Vs2vf9AarvUXsQ
        TSLVbKqlfVOuQqo5xFfoPQhITKWkvLdnJKpAU3GEM5TsNZQXcbwHLSBxVSq1Jbdqj4LWasq4
        gxxXyhn+VyVk0nwjsmxT52d26EZHstN3jWpTAsjWuerk/axvvwJHw1q1e3qRS1uw4/nO8Ff9
        rFPBBmNlXr83fVtkGZtjCLkt699e63ut76i7u7Tff07tkuxuzjmtjJyYWvxblV9Ita/LXPAt
        2052n/j4ZajJUl71asztf1VqXG571n3gUmtZ02DrbL8K5ws1a1dgBl7zDw85dflXAwAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t/xK7rFh2yiDJY0yli8PzWR3WLjjPWs
        FvOPnGO16H4lY9H/+DWzxfnzG9gtbh5awWhx/95PJovLu+awWcw4v4/JYsG2PkaLpf3HGS1a
        9x5hd+D12DnrLrvHtgOqHptWdbJ59G1ZxejR93IDo8fxG9uZPD5vkgtgj+KySUnNySxLLdK3
        S+DKODlrFkvBIvaKwz232RoYZ7B1MXJwSAiYSDzendbFyAlkiklcuLceKMzFISSwhFFi5Z2v
        jCAJXgFBiR+T77GA2MwCZhJfXh5mhSh6zigx9dwFZpBBwgJ+Eo1LYkFqRAQyJe41/2UEqWEW
        WMgsMfPWPBaIhg+MEksvH2MFqWITMJToetvFBrHBTuLGzRlMIDaLgKrE3FlbwWpEBWIkDvdM
        B7M5BSwlHhx7CHWFvMTBK8+hbHGJ5tabLBMYBWchOXYWkmNnIWmZhaRlASPLKkaR1NLi3PTc
        YiO94sTc4tK8dL3k/NxNjMAI23bs55YdjF3vgg8xCnAwKvHwbthpHSXEmlhWXJl7iFGCg1lJ
        hPfwEqAQb0piZVVqUX58UWlOavEhRmkOFiVx3t49qyOFBNITS1KzU1MLUotgskwcnFINjJPF
        zGUSp56bsL18pTG3sJ0X0z4Pr3lfHq3IC3j9VO3XFZn9fzL/TJSwNRX/+Wlxl3xq9PXcmXFR
        Lxe0rZhhnaQtUMa75vMyRR2njCLfbzEVWw441QdOu9g2bw5PY+i3xfJi/L8driwN+OlXmZn4
        5qBYUDf7pZBzZcaqeWd/NSZyfJ9rEeskqMRSnJFoqMVcVJwIAAvwpzCsAgAA
X-CMS-MailID: 20171222082939eucas1p1da02ca212717173cc1272432e3404ae6
X-Msg-Generator: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20171204125415eucas1p1f94e6996f08938f686c08c00247c62ce
X-RootMTR: 20171204125415eucas1p1f94e6996f08938f686c08c00247c62ce
References: <20171204125351.26805-1-l.stelmach@samsung.com>
        <CGME20171204125415eucas1p1f94e6996f08938f686c08c00247c62ce@eucas1p1.samsung.com>
        <20171204125351.26805-3-l.stelmach@samsung.com>
        <20171222082412.GB29663@gondor.apana.org.au>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 2017-12-22 09:24, Herbert Xu wrote:
> On Mon, Dec 04, 2017 at 01:53:50PM +0100, Łukasz Stelmach wrote:
>> Add support for True Random Number Generator found in Samsung Exynos
>> 5250+ SoCs.
>>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> This doesn't build for me:
>
>    CC [M]  drivers/char/hw_random/exynos-trng.o
> ../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018exynos_rng_dt_match\u2019 undeclared here (not in a function)
> ../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018__mod_of__exynos_rng_dt_match_device_table\u2019 aliased to undefined symbol \u2018exynos_rng_dt_match\u2019
> make[2]: *** [drivers/char/hw_random/exynos-trng.o] Error 1
> make[1]: *** [_module_drivers/char/hw_random] Error 2

This looks like a missing dependency on "OF" when "COMPILE_TEST" is 
selected.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland