From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Francesco Dolcini <francesco.dolcini@toradex.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Joakim Zhang" <qiangqing.zhang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Csókás Bence" <csokas.bence@prolan.hu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Guenter Roeck" <linux@roeck-us.net>,
"Andrew Lunn" <andrew@lunn.ch>
Subject: Re: [PATCH net 0/2] Revert fec PTP changes
Date: Tue, 20 Sep 2022 09:45:39 +0200 [thread overview]
Message-ID: <9165d763-ec2c-3014-cebf-121934ad93f3@leemhuis.info> (raw)
In-Reply-To: <20220912123833.GA4303@francesco-nb.int.toradex.com>
On 12.09.22 14:38, Francesco Dolcini wrote:
> On Mon, Sep 12, 2022 at 02:28:57PM +0200, Marc Kleine-Budde wrote:
>> On 12.09.2022 09:01:41, Francesco Dolcini wrote:
>>> Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple
>>> issues and we are at 6.0-rc5.
>>>
>>> Francesco Dolcini (2):
>>> Revert "fec: Restart PPS after link state change"
>>> Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`"
>>
>> Nitpick: I would revert "net: fec: Use a spinlock to guard
>> `fep->ptp_clk_on`" first, as it's the newer patch.
>
> Shame on me, I do 100% agree, I inverted the 2 patches last second.
What's the status of this patchset? It seems it didn't make any progress
in the past few days, or am I missing something?
Just asking, because the thing is: I'm pretty sure that Linus will be
somewhat unhappy if there isn't any attempt to get this fixed before
rc7, as the the problems caused by these patches are known for a while now.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.
next prev parent reply other threads:[~2022-09-20 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 7:01 [PATCH net 0/2] Revert fec PTP changes Francesco Dolcini
2022-09-12 7:01 ` [PATCH net 1/2] Revert "fec: Restart PPS after link state change" Francesco Dolcini
2022-09-12 12:07 ` Andrew Lunn
2022-09-12 12:32 ` Marc Kleine-Budde
2022-09-12 7:01 ` [PATCH net 2/2] Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" Francesco Dolcini
2022-09-12 12:05 ` Andrew Lunn
2022-09-12 12:32 ` Marc Kleine-Budde
2022-09-12 7:07 ` [PATCH net 0/2] Revert fec PTP changes Francesco Dolcini
2022-09-12 12:28 ` Marc Kleine-Budde
2022-09-12 12:38 ` Francesco Dolcini
2022-09-20 7:45 ` Thorsten Leemhuis [this message]
2022-09-20 9:51 ` Paolo Abeni
2022-09-20 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9165d763-ec2c-3014-cebf-121934ad93f3@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=andrew@lunn.ch \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).