linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eads, Gage" <gage.eads@intel.com>
To: "Raj, Ashok" <ashok.raj@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	Joerg Roedel <joro@8bytes.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	"Alan Cox" <gnomes@lxorguk.ukuu.org.uk>
Subject: RE: [PATCH] vfio/pci: Some buggy virtual functions incorrectly report 1 for intx.
Date: Wed, 19 Sep 2018 22:25:03 +0000	[thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E44721113@fmsmsx101.amr.corp.intel.com> (raw)
In-Reply-To: <20180919194617.GA14924@otc-nc-03>

> This looks good and also addresses Alan's concern that don't silently hide under
> the rug for all devices. We'll also queue it for testing just to confirm and keep
> you posted.
> 
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> 

Hi Alex,

I've confirmed that the patch works as intended for the 8086:270c device, and negative tested the warning by commenting out the device's entry in known_bogus_vf_intx_pin.

For what it's worth, my positive test case - launching a QEMU VM with a VFIO-owned 0x270c device - did not trigger the warning. This is because the change to vfio_pci_config.c caused QEMU to read a PCI_INTERRUPT_PIN value of 0, and so didn't execute a codepath that calls vfio_pci_get_irq_count(). Instead, I used a simple C program that calls the VFIO_DEVICE_GET_IRQ_INFO ioctl for negative testing.

Also, there's one typo in the comment: 'quite' -> 'quiet'

Tested-by: Gage Eads <gage.eads@intel.com>

Thanks,
Gage

  parent reply	other threads:[~2018-09-19 22:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 19:37 [PATCH] vfio/pci: Some buggy virtual functions incorrectly report 1 for intx Ashok Raj
2018-08-09 19:44 ` Alex Williamson
2018-08-09 23:03   ` Raj, Ashok
2018-08-10 16:48     ` Alan Cox
2018-08-10 16:54       ` Raj, Ashok
2018-09-12 17:46   ` Raj, Ashok
2018-09-19  3:59     ` Alex Williamson
     [not found]       ` <20180919194617.GA14924@otc-nc-03>
2018-09-19 22:25         ` Eads, Gage [this message]
2018-09-19 22:47           ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9184057F7FC11744A2107296B6B8EB1E44721113@fmsmsx101.amr.corp.intel.com \
    --to=gage.eads@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=ashok.raj@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=helgaas@kernel.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).