From: Pavel Begunkov <asml.silence@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree
Date: Sat, 27 Jun 2020 14:18:40 +0300 [thread overview]
Message-ID: <918e3d02-8478-e647-5e16-1f1cb256ea36@gmail.com> (raw)
In-Reply-To: <20200627150153.331c66e7@canb.auug.org.au>
On 27/06/2020 08:01, Stephen Rothwell wrote:
> Hi Konstantin,
>
> On Fri, 26 Jun 2020 21:56:05 -0400 Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>>
>> On Fri, Jun 26, 2020 at 07:32:15PM -0600, Jens Axboe wrote:
>>> On 6/26/20 5:07 PM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>> cd664b0e35cb ("io_uring: fix hanging iopoll in case of -EAGAIN")
>>>>
>>>> Fixes tag
>>>>
>>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>>
>>>> has these problem(s):
>>>>
>>>> - Subject has leading but no trailing parentheses
>>>> - Subject has leading but no trailing quotes
>>>>
>>>> Please do not split Fixes tags over more than one line.
>>>
>>> Gah, that's b4 messing it up. I've actually seen this before, but
>>> I caught it. If you look at the actual commit, this is what the b4
>>> output ends up being for the fixes line:
>>>
>>> [snip]
>>> io_kiocb's result and iopoll_completed")
>>>
>>> Fixes: bbde017a32b3 ("io_uring: add memory barrier to synchronize
>>>
>>> even though it's correct in the email. I'm guessing some issue having to
>>> do with the longer line?
>>
>> Yeah, I'll try to see if there's something I can do here, but it's going
>> to be largely guesswork. Here's the original email:
>>
>> https://lore.kernel.org/lkml/22111b29e298f5f606130fcf4307bda99dbec089.1593077359.git.asml.silence@gmail.com/raw
>>
>> The Fixes: footer really does get split into two. It's not that hard to
>> add logic just for the Fixes tag (since it conveniently follows a set
>> pattern), but finding a universal fix for split footers will be more
>> difficult.
>>
>> I'll see what I can do.
>
> But (what am I missing?) the Fixes: tag has been split over 2 lines in
> the original message ... on lore and my copy. There is nothing for b4
> to do here, the author needs to do this right.
Yes, it was split from the beginning. It's really a shame it can't handle
multi-line tags, but well, I'll keep that in mind.
Though, it's curious how
```
Fixes ("line1
line2")
```
became
```
line2")
Fixes ("line1
```
And that's what the rest of the thread is about.
--
Pavel Begunkov
next prev parent reply other threads:[~2020-06-27 11:20 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 23:07 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
2020-06-27 1:32 ` Jens Axboe
2020-06-27 1:56 ` Konstantin Ryabitsev
2020-06-27 2:25 ` Jens Axboe
2020-06-27 5:12 ` Stephen Rothwell
2020-06-28 13:38 ` Jens Axboe
2020-06-27 5:01 ` Stephen Rothwell
2020-06-27 11:18 ` Pavel Begunkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 21:51 Stephen Rothwell
2023-08-14 23:19 Stephen Rothwell
2023-08-15 3:21 ` Yu Kuai
2023-08-15 15:08 ` Jens Axboe
2023-08-15 15:58 ` Song Liu
2023-08-15 16:07 ` Jens Axboe
2023-08-15 16:17 ` Song Liu
2023-08-15 16:20 ` Jens Axboe
2023-08-15 16:26 ` Song Liu
2023-08-15 16:31 ` Jens Axboe
2023-08-15 16:51 ` Song Liu
2023-08-15 16:59 ` Jens Axboe
2023-06-18 22:22 Stephen Rothwell
2023-06-20 5:41 ` Chaitanya Kulkarni
2023-06-13 22:33 Stephen Rothwell
2023-03-20 21:28 Stephen Rothwell
2023-03-20 21:30 ` Jens Axboe
2022-11-28 21:27 Stephen Rothwell
2022-11-28 23:39 ` Damien Le Moal
2022-11-29 2:30 ` Jens Axboe
2022-11-29 2:50 ` Damien Le Moal
2022-07-27 22:06 Stephen Rothwell
2022-06-22 23:21 Stephen Rothwell
2022-06-22 23:44 ` Jens Axboe
2022-06-23 8:11 ` Dylan Yudaken
2022-04-28 1:44 Stephen Rothwell
2022-03-28 21:02 Stephen Rothwell
2022-03-22 20:49 Stephen Rothwell
2022-03-23 1:45 ` Jens Axboe
2022-01-03 21:25 Stephen Rothwell
2021-10-19 21:46 Stephen Rothwell
2021-08-22 3:24 Stephen Rothwell
2021-05-18 22:01 Stephen Rothwell
2021-05-19 19:25 ` Sergey Shtylyov
2021-05-19 21:55 ` Jens Axboe
2021-05-05 22:23 Stephen Rothwell
2021-05-09 1:49 ` Minwoo Im
2021-03-04 23:52 Stephen Rothwell
2021-03-05 0:26 ` Jens Axboe
2021-03-05 7:46 ` Christoph Hellwig
2021-03-05 15:53 ` Jens Axboe
2021-02-22 21:01 Stephen Rothwell
2021-02-22 21:15 ` Chaitanya Kulkarni
2021-02-20 4:51 Stephen Rothwell
2021-02-20 4:57 ` Jens Axboe
2021-02-04 20:13 Stephen Rothwell
2021-01-25 9:40 Stephen Rothwell
2021-01-25 18:35 ` Paolo Valente
2021-01-25 18:39 ` Jens Axboe
2021-01-26 13:29 ` Jan Kara
2021-01-26 15:47 ` Jens Axboe
2021-01-26 16:01 ` Jan Kara
2021-01-26 16:05 ` Jens Axboe
2020-12-17 20:38 Stephen Rothwell
2020-12-17 20:42 ` Jens Axboe
2020-12-01 21:02 Stephen Rothwell
2020-12-01 21:09 ` Jens Axboe
2020-12-01 21:44 ` Stephen Rothwell
2020-12-01 21:52 ` Jens Axboe
2020-11-30 21:28 Stephen Rothwell
2020-09-24 22:38 Stephen Rothwell
2020-07-29 22:08 Stephen Rothwell
2020-07-29 22:12 ` Stephen Rothwell
2020-07-30 15:04 ` Jens Axboe
2020-06-28 22:05 Stephen Rothwell
2020-06-29 16:21 ` Pavel Begunkov
2020-06-29 16:25 ` Jens Axboe
2020-06-29 22:36 ` Stephen Rothwell
2020-06-29 22:45 ` Jens Axboe
2020-05-28 21:10 Stephen Rothwell
2020-03-22 14:08 Stephen Rothwell
2019-10-24 6:16 Stephen Rothwell
2019-10-07 20:16 Stephen Rothwell
2019-10-10 17:36 ` Bart Van Assche
2019-10-11 0:42 ` Stephen Rothwell
2019-09-10 14:57 Stephen Rothwell
2019-07-11 21:35 Stephen Rothwell
2019-07-11 22:03 ` Jens Axboe
2019-07-12 8:47 ` Minwoo Im
2019-02-21 20:39 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918e3d02-8478-e647-5e16-1f1cb256ea36@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).