From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbcI1TwB (ORCPT ); Wed, 28 Sep 2016 15:52:01 -0400 Received: from kozue.soulik.info ([108.61.200.231]:40718 "EHLO kozue.soulik.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbcI1Tvw (ORCPT ); Wed, 28 Sep 2016 15:51:52 -0400 Subject: Re: [RFC PATCH v3 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel To: Rob Herring References: <1474311771-23321-1-git-send-email-ayaka@soulik.info> <1474311771-23321-3-git-send-email-ayaka@soulik.info> <20160923180042.GA7132@rob-hp-laptop> Cc: dri-devel@lists.freedesktop.org, linux@armlinux.org.uk, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, airlied@linux.ie, a.hajda@samsung.com, devicetree@vger.kernel.org From: ayaka Message-ID: <91b2efcc-4a74-c965-2163-a26a7f11fcd0@soulik.info> Date: Thu, 29 Sep 2016 03:51:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160923180042.GA7132@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2016 02:00 AM, Rob Herring wrote: > On Tue, Sep 20, 2016 at 03:02:51AM +0800, Randy Li wrote: >> The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be >> supported by the simple panel driver. >> >> Signed-off-by: Randy Li >> --- >> .../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> new file mode 100644 >> index 0000000..dd22685 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt >> @@ -0,0 +1,7 @@ >> +Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "chunghwa,claa070wp03xg" > What about VCC, VLED, LED_EN (PWM), LVBIT, LVFMT, DITHER signals? I didn't see the other simple-panel has that, so I didn't neither. And I think it would only have VCC and LED_EN(PWM). > >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory.