From: "Christian König" <christian.koenig@amd.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Matt Roper <matthew.d.roper@intel.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/19] dma-buf-map: Add read/write helpers
Date: Thu, 27 Jan 2022 08:24:04 +0100 [thread overview]
Message-ID: <91bfa9d4-99fc-767e-5ba2-a2643cf585f5@amd.com> (raw)
In-Reply-To: <20220126203702.1784589-2-lucas.demarchi@intel.com>
Am 26.01.22 um 21:36 schrieb Lucas De Marchi:
> In certain situations it's useful to be able to read or write to an
> offset that is calculated by having the memory layout given by a struct
> declaration. Usually we are going to read/write a u8, u16, u32 or u64.
>
> Add a pair of macros dma_buf_map_read_field()/dma_buf_map_write_field()
> to calculate the offset of a struct member and memcpy the data from/to
> the dma_buf_map. We could use readb, readw, readl, readq and the write*
> counterparts, however due to alignment issues this may not work on all
> architectures. If alignment needs to be checked to call the right
> function, it's not possible to decide at compile-time which function to
> call: so just leave the decision to the memcpy function that will do
> exactly that on IO memory or dereference the pointer.
>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: linux-media@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> include/linux/dma-buf-map.h | 81 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 81 insertions(+)
>
> diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h
> index 19fa0b5ae5ec..65e927d9ce33 100644
> --- a/include/linux/dma-buf-map.h
> +++ b/include/linux/dma-buf-map.h
> @@ -6,6 +6,7 @@
> #ifndef __DMA_BUF_MAP_H__
> #define __DMA_BUF_MAP_H__
>
> +#include <linux/kernel.h>
> #include <linux/io.h>
> #include <linux/string.h>
>
> @@ -229,6 +230,46 @@ static inline void dma_buf_map_clear(struct dma_buf_map *map)
> }
> }
>
> +/**
> + * dma_buf_map_memcpy_to_offset - Memcpy into offset of dma-buf mapping
> + * @dst: The dma-buf mapping structure
> + * @offset: The offset from which to copy
> + * @src: The source buffer
> + * @len: The number of byte in src
> + *
> + * Copies data into a dma-buf mapping with an offset. The source buffer is in
> + * system memory. Depending on the buffer's location, the helper picks the
> + * correct method of accessing the memory.
> + */
> +static inline void dma_buf_map_memcpy_to_offset(struct dma_buf_map *dst, size_t offset,
> + const void *src, size_t len)
> +{
> + if (dst->is_iomem)
> + memcpy_toio(dst->vaddr_iomem + offset, src, len);
> + else
> + memcpy(dst->vaddr + offset, src, len);
> +}
> +
> +/**
> + * dma_buf_map_memcpy_from_offset - Memcpy from offset of dma-buf mapping into system memory
> + * @dst: Destination in system memory
> + * @src: The dma-buf mapping structure
> + * @src: The offset from which to copy
> + * @len: The number of byte in src
> + *
> + * Copies data from a dma-buf mapping with an offset. The dest buffer is in
> + * system memory. Depending on the mapping location, the helper picks the
> + * correct method of accessing the memory.
> + */
> +static inline void dma_buf_map_memcpy_from_offset(void *dst, const struct dma_buf_map *src,
> + size_t offset, size_t len)
> +{
> + if (src->is_iomem)
> + memcpy_fromio(dst, src->vaddr_iomem + offset, len);
> + else
> + memcpy(dst, src->vaddr + offset, len);
> +}
> +
Well that's certainly a valid use case, but I suggest to change the
implementation of the existing functions to call the new ones with offset=0.
This way we only have one implementation.
> /**
> * dma_buf_map_memcpy_to - Memcpy into dma-buf mapping
> * @dst: The dma-buf mapping structure
> @@ -263,4 +304,44 @@ static inline void dma_buf_map_incr(struct dma_buf_map *map, size_t incr)
> map->vaddr += incr;
> }
>
> +/**
> + * dma_buf_map_read_field - Read struct member from dma-buf mapping with
> + * arbitrary size and handling un-aligned accesses
> + *
> + * @map__: The dma-buf mapping structure
> + * @type__: The struct to be used containing the field to read
> + * @field__: Member from struct we want to read
> + *
> + * Read a value from dma-buf mapping calculating the offset and size: this assumes
> + * the dma-buf mapping is aligned with a a struct type__. A single u8, u16, u32
> + * or u64 can be read, based on the offset and size of type__.field__.
> + */
> +#define dma_buf_map_read_field(map__, type__, field__) ({ \
> + type__ *t__; \
> + typeof(t__->field__) val__; \
> + dma_buf_map_memcpy_from_offset(&val__, map__, offsetof(type__, field__), \
> + sizeof(t__->field__)); \
> + val__; \
> +})
> +
> +/**
> + * dma_buf_map_write_field - Write struct member to the dma-buf mapping with
> + * arbitrary size and handling un-aligned accesses
> + *
> + * @map__: The dma-buf mapping structure
> + * @type__: The struct to be used containing the field to write
> + * @field__: Member from struct we want to write
> + * @val__: Value to be written
> + *
> + * Write a value to the dma-buf mapping calculating the offset and size.
> + * A single u8, u16, u32 or u64 can be written based on the offset and size of
> + * type__.field__.
> + */
> +#define dma_buf_map_write_field(map__, type__, field__, val__) ({ \
> + type__ *t__; \
> + typeof(t__->field__) val____ = val__; \
> + dma_buf_map_memcpy_to_offset(map__, offsetof(type__, field__), \
> + &val____, sizeof(t__->field__)); \
> +})
> +
Uff well that absolutely looks like overkill to me.
That's a rather special use case as far as I can see and I think we
should only have this in the common framework if more than one driver is
using it.
Regards,
Christian.
> #endif /* __DMA_BUF_MAP_H__ */
next prev parent reply other threads:[~2022-01-27 7:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 20:36 [PATCH 00/19] drm/i915/guc: Refactor ADS access to use dma_buf_map Lucas De Marchi
2022-01-26 20:36 ` [PATCH 01/19] dma-buf-map: Add read/write helpers Lucas De Marchi
2022-01-27 7:24 ` Christian König [this message]
2022-01-27 7:36 ` Matthew Brost
2022-01-27 7:59 ` Christian König
2022-01-27 9:02 ` [Intel-gfx] " Daniel Vetter
2022-01-27 14:26 ` Thomas Zimmermann
2022-01-27 16:34 ` Lucas De Marchi
2022-01-28 8:32 ` Thomas Zimmermann
2022-01-26 20:36 ` [PATCH 02/19] dma-buf-map: Add helper to initialize second map Lucas De Marchi
2022-01-27 7:27 ` Christian König
2022-01-27 7:57 ` Lucas De Marchi
2022-01-27 8:02 ` Christian König
2022-01-27 8:18 ` [Intel-gfx] " Lucas De Marchi
2022-01-27 8:55 ` Christian König
2022-01-27 9:12 ` Lucas De Marchi
2022-01-27 9:21 ` Christian König
2022-01-27 8:57 ` Daniel Vetter
2022-01-27 9:33 ` [Intel-gfx] " Lucas De Marchi
2022-01-27 10:00 ` Daniel Vetter
2022-01-27 10:21 ` Christian König
2022-01-27 11:16 ` Daniel Vetter
2022-01-27 11:44 ` [Linaro-mm-sig] " Christian König
2022-01-27 11:56 ` Daniel Vetter
2022-01-27 16:13 ` Lucas De Marchi
2022-01-27 14:52 ` Thomas Zimmermann
2022-01-27 16:12 ` Lucas De Marchi
2022-01-27 14:33 ` Thomas Zimmermann
2022-01-27 15:59 ` [Intel-gfx] " Lucas De Marchi
2022-01-28 8:15 ` Thomas Zimmermann
2022-01-28 8:34 ` Thomas Zimmermann
2022-01-26 20:36 ` [PATCH 09/19] dma-buf-map: Add wrapper over memset Lucas De Marchi
2022-01-27 7:28 ` Christian König
2022-01-27 14:54 ` Thomas Zimmermann
2022-01-27 15:38 ` [Intel-gfx] " Lucas De Marchi
2022-01-27 15:47 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91bfa9d4-99fc-767e-5ba2-a2643cf585f5@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).