From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8201DC38A2D for ; Wed, 26 Oct 2022 14:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234188AbiJZOMT (ORCPT ); Wed, 26 Oct 2022 10:12:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233485AbiJZOMQ (ORCPT ); Wed, 26 Oct 2022 10:12:16 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8F6A106E0F for ; Wed, 26 Oct 2022 07:12:15 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id hh9so9912645qtb.13 for ; Wed, 26 Oct 2022 07:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pGbHuCEYdpPdrNmRy3KRJXWEMPpe/Yl4yYbiL7G5pI4=; b=aI3SgU/o1B2M/H6X1N1ybICwefhQuyMnMU+xDhAda4rQ9GF9Hn7lTutEP2dSljFwDm LNGUaLiXZkIFCetzK0stTLFVY5xkl+5x4+O2aE1xzGKzPEnjThfdaH5mdD8wRlGQF3Ar zdLQGyIpYGveQVdB3InsYbQgbhjDfjY9o6Op7+cXJ8NDgmla2LaU4k/EJ8GfvJ1Kvdjp kNzeeCsxiTkNZoTXEydWORLk54L2rnVam0Iv3Cm8mkk8TevcoUuWl8R1ODrD4aoAa/Bz BgtAulbiOtieEdpBIEDG1iZQdBLcOsEXG7Rc1H1V+bRFaL3Tct4sayaA68UEvuJbRN/M lTqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pGbHuCEYdpPdrNmRy3KRJXWEMPpe/Yl4yYbiL7G5pI4=; b=sh36eQaGYf3O55KuR0ZuoOZHsOJ/Ddl8McFTIvPKeEO9fwGXaoDJNSDATpnUMs9VpI NJlk2r4J1vyZveSvh8ftxz9PjwKosrsrM6LO+4uOaMClA12Je2iKVeBPtWdaXoFn/PmO 7aOYABKBb2tSbQxHqI6UtnJk1DVzw3VOmHZ8O1n+DNnBNpB345dgEq2R2tPx/sZm4sF3 h8s4UWSzamn4JgwzWRi5KJhF+MSv4CAvgS+GyzrOr+13wrl5JM5GW8pnGo7reh+de22P xUgzAJskALPN0yoar2PVM3shRq/d+i48VNqPFD1hZa1A5nXHg06Q5hzs0GhPdk7BCBR3 d6hA== X-Gm-Message-State: ACrzQf18JOLeDtOWTRgWascbdHm/ybTAFPTmZMb+A2AICxhj+fgT2S2w zRyFmKQ74IoACBiEwGxmIntbjw== X-Google-Smtp-Source: AMsMyM7b/EkQh+RWqeoLHn2b9Hjxnnpl67n8IyVDCyNP1zMzoVmRnoUDP8KhxgY6DseThPc6o+7mNA== X-Received: by 2002:ac8:5cc6:0:b0:3a4:e3a6:5dd5 with SMTP id s6-20020ac85cc6000000b003a4e3a65dd5mr5599860qta.468.1666793535009; Wed, 26 Oct 2022 07:12:15 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id de30-20020a05620a371e00b006e99290e83fsm2417302qkb.107.2022.10.26.07.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 07:12:14 -0700 (PDT) Message-ID: <91e83eeb-24b5-4602-c132-c23a2fb5d756@linaro.org> Date: Wed, 26 Oct 2022 10:12:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-US To: Andrej Picej , linux-watchdog@vger.kernel.org, Alexander Stein Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221025072533.2980154-1-andrej.picej@norik.com> <20221025072533.2980154-3-andrej.picej@norik.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/2022 02:38, Andrej Picej wrote: > On 25. 10. 22 15:48, Krzysztof Kozlowski wrote: >> On 25/10/2022 03:25, Andrej Picej wrote: >>> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which >>> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not >>> set and the device is put into Suspend-to-Idle mode, the watchdog >>> triggers a reset after 128 seconds. >>> >>> Signed-off-by: Andrej Picej >>> Reviewed-by: Fabio Estevam >>> --- >>> Changes in v2: >>> - add a commit message, >>> - add a list of devices which support this functionality >>> --- >>> .../bindings/watchdog/fsl-imx-wdt.yaml | 22 +++++++++++++++++++ >>> 1 file changed, 22 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> index fb7695515be1..9289de97859b 100644 >>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> @@ -55,6 +55,28 @@ properties: >>> If present, the watchdog device is configured to assert its >>> external reset (WDOG_B) instead of issuing a software reset. >>> >>> + fsl,suspend-in-wait: >>> + $ref: /schemas/types.yaml#/definitions/flag >>> + description: | >>> + If present, the watchdog device is suspended in WAIT mode >>> + (Suspend-to-Idle). Only supported on following devices: >>> + - "fsl,imx25-wdt", >> >> You need to define such allow/disallow in allOf:if:then, instead. Like >> example-schema is doing for foo-supply, just disallow it for some types >> or use "if: not: ..." > > Sorry missed that. So something like that should be added?: > >> allOf: >> - if: >> not: >> properties: >> compatible: >> contains: >> enum: >> - fsl,imx25-wdt >> - fsl,imx35-wdt >> - fsl,imx50-wdt >> - fsl,imx51-wdt >> - fsl,imx53-wdt >> - fsl,imx6q-wdt >> - fsl,imx6sl-wdt >> - fsl,imx6sll-wdt >> - fsl,imx6sx-wdt >> - fsl,imx6ul-wdt >> - fsl,imx7d-wdt >> - fsl,imx8mm-wdt >> - fsl,imx8mn-wdt >> - fsl,imx8mp-wdt >> - fsl,imx8mq-wdt >> - fsl,vf610-wdt Yes. >> then: >> properties: >> fsl,suspend-in-wait: false > > And I'm assuming I can then remove the supported devices list from > property description. Yes. > > Are you fine with this, so we don't have to split the compatible list > like Alexander suggested? Basically we have the same list of WDW > supported devices in the driver. I don't know to what you refer. Best regards, Krzysztof