From: John Garry <john.garry@huawei.com>
To: Jason Yan <yanaijie@huawei.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs
Date: Tue, 12 May 2020 11:00:53 +0100 [thread overview]
Message-ID: <920c5d36-5637-1fba-034b-8ea3d41c131c@huawei.com> (raw)
In-Reply-To: <dacd7cbe-3d84-2b35-e63a-af6179aa5221@huawei.com>
On 12/05/2020 10:35, Jason Yan wrote:
>
>
> 在 2020/5/12 16:23, John Garry 写道:
>> On 12/05/2020 07:33, Jason Yan wrote:
>>> The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase it is
>>> not initialized in scsi_host_template. It looks like:
>>>
>>> [root@localhost ~]# cat /sys/class/scsi_host/host2/proc_name
>>> (null)
>>>
>>
>> hmmm.. it would be good to tell us what this buys us, apart from the
>> proc_name file.
>>
>
> When there is more than one storage cards(or controllers) in the system,
> I'm tring to find out which host is belong to which card. And then I
> found this in scsi_host in sysfs but the output is '(null)' which is odd.
"dmesg | grep host" would give this info, like:
root@(none)$ dmesg | grep host0
[ 8.877245] scsi host0: hisi_sas_v2_hw
>
>> I mean, if we had the sht show_info method implemented, then it could
>> be useful (which is even marked as obsolete now).
>>
>
> I found this is interesting while in the sysfs filesystem we have a
> procfs stuff in it.
It's only the name of the procfs entry, if it exists.
And, since .show_info is obsolete, I don't see why .proc_name is not
also obsolete.
> I was planned to rename this entry to 'name' and use
> the struct member 'name' directly in struct scsi_host_template. But this
> may break userspace applications.
>
Thanks,
John
next prev parent reply other threads:[~2020-05-12 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 6:33 [PATCH] scsi: hisi_sas: display correct proc_name in sysfs Jason Yan
2020-05-12 8:23 ` John Garry
2020-05-12 9:35 ` Jason Yan
2020-05-12 10:00 ` John Garry [this message]
2020-05-12 10:30 ` Jason Yan
2020-05-12 11:07 ` John Garry
2020-05-12 11:29 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=920c5d36-5637-1fba-034b-8ea3d41c131c@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).