From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1430576AbdDYMqr (ORCPT ); Tue, 25 Apr 2017 08:46:47 -0400 Received: from mout.web.de ([212.227.15.14]:62754 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1430539AbdDYMql (ORCPT ); Tue, 25 Apr 2017 08:46:41 -0400 Subject: [PATCH 2/2] HSI: core: Use kcalloc() in two functions From: SF Markus Elfring To: "Andrew F. Davis" , Carlos Chinea , Linus Walleij , Sebastian Reichel Cc: LKML , kernel-janitors@vger.kernel.org References: <52f7db50-a3a0-6bc5-a39f-1d235a5945cd@users.sourceforge.net> Message-ID: <921ba1f4-132c-18b6-f5ff-99b9f3e562d9@users.sourceforge.net> Date: Tue, 25 Apr 2017 14:46:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <52f7db50-a3a0-6bc5-a39f-1d235a5945cd@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pN/UgP2t6AcfrhVqEIsZ+YLsHcY0+tsmsVZ7gAUO386yFYdsNPY Pc1NWrC0FN1mU/UbRnnXi0n2avtK/QzP+lBPqg2s8h4G8DJAOHPUFMIUA8pUDsq6OP/Q5F3 wcs7uVJaP4x8jvaAWvbVy2EXHtruS+Xl4q+FLgGZ8neWtVGXj5XP0ytBQMKW9394Jnupbzr y0RyfkpB2UCzBFDv2q5dQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:3O/+YdDH+rA=:Rras6plBOMJTOGeRSHLESu tvfaez6OtUV2RBC3600r2948Yd1SrTEy2Uma/FXaorOZIK32vLDzRvmV/bhDaMFIeIFLijI1g wzxMQtHIG1pJNNUhaSnLA+HdF+dpXTvYWHO5SpUAil1TPPIoX3H27/T2rXAS+RcapXYUkDD0c heucbcU4SEBfSQY5VdUipl6qWd3UEo3Juh66e1Ff1mxluqpwEGpH+zgE2oF/ml3zzct7/af74 +vN3s55AxfgW6U4xzSAUygN4sEvxhrNvi7NSBu9jZWRi5DBzJuBsU/oiwCxqHMMBfuQpqfd3x ylWlNNMsAWSY4SkiXJFQl5GF/tssmSOPGnTAV2Sn6EjCtuZhUskGXpLOYDqZ1WG8g4zdwzAyh tVulWPcjnErzB614kgB0El3NHbGotgs7jSw9NxP3h4LCLkpcF2llLMQhGlFLCrOrEludDPXbj JK8RnFW8CdSvv8K7NyT2fraX4KzJIWK7yYaBhWmu4EB1IV0X69XhZUabn3tgI4TWO/jrdEhdE iVGhbNKOSXCSmE/CI/RC41NE7DFwO9bmkq89wr64r0mDH1/6nz031KdjXWDFMd+03A/FhZYLs x55HZopIoyu7DM6LkkCn7ldRR7leigNXUuA1X/TwfpB3FX+hgL/M2hr7EBefszl4ozkuvio/9 YroWGqIP69zMVuyCz5Uj/JppLhIRSWrD3/d1fEr/FiCogPMwSFpY2a1owHsJcSfMGu2xIPSpu gACC+0WHeYThf6dZp4yVP3AepqANPjqnL3ZeIs3XtRcLqKdXEq/+PkfM8zwrcs898ppLgPjzF 3iLByoh Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 25 Apr 2017 14:17:50 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hsi/hsi_core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index c2a2a9795b0b..9065efd21851 100644 --- a/drivers/hsi/hsi_core.c +++ b/drivers/hsi/hsi_core.c @@ -267,14 +267,13 @@ static void hsi_add_client_from_dt(struct hsi_port *port, cl->rx_cfg.num_channels = cells; cl->tx_cfg.num_channels = cells; - - cl->rx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL); + cl->rx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL); if (!cl->rx_cfg.channels) { err = -ENOMEM; goto err; } - cl->tx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL); + cl->tx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL); if (!cl->tx_cfg.channels) { err = -ENOMEM; goto err2; @@ -485,7 +484,7 @@ struct hsi_controller *hsi_alloc_controller(unsigned int n_ports, gfp_t flags) hsi = kzalloc(sizeof(*hsi), flags); if (!hsi) return NULL; - port = kzalloc(sizeof(*port)*n_ports, flags); + port = kcalloc(n_ports, sizeof(*port), flags); if (!port) { kfree(hsi); return NULL; -- 2.12.2