From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752254AbcADPS0 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 10:18:26 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:57628 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751688AbcADPSW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 10:18:22 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Brown <broonie@kernel.org>, Brian Austin <brian.austin@cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Paul Handrigan <Paul.Handrigan@cirrus.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access
Date: Mon, 04 Jan 2016 16:17:47 +0100
Message-ID: <9222694.IRNnfpj6Tn@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160102141746.GH16023@sirena.org.uk>
References: <2884997.s8B8BuE04L@wuerfel> <20160102141746.GH16023@sirena.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:h550EDXe4Vj+mF21v741JcFsjpnuSKJ8mqK1rZ7N8u//dHAjSee
 ypG57diERXDoW5OR0xu0+CYKb5bR3hyg4fBhapqcmrAgizWg0WPJxn82DRK01s4XjhvKXmX
 AiAlwnVqVLrQdSBUAf1zu4+W711wzEdOgEqWElwLyNWKWL5TSenHo3uvV+zBniaSiJAvMah
 27dbOXsP7VCFk37Ta9taQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Jbp4j5f5h9U=:UqwvhY29wqDLdIHgf+ihT0
 9FnxKf68hFthxoqZS0qpXi3L++1zWsBVlKGq4k7alt1aHuZD4BtPUh6JLZC9t4CpohfIobkwE
 d0EJpr1ALGTMZpvFsHU6Roz60X2ore6aspFw2ErcifAETcpYSWHzy1ZazBD7Qw/zynRIIE6d8
 4oJhyLUImjv3m4l7AiGSnktCHa+z9HxsLpGkZ7hPQj5Uj7PObbLWiRbFCGJwtTsQJ6bcSXgib
 w09RmUj0ZwhwibGNcmw1HvSSYOgVbrRHRvzZVPmNIqMKTxzxFW3bS415qGimXITA1Gils7hq5
 LaRKfQ11nAa8smQysD8e09Irn4NxwjFjoRA4erDw5ufJMFA21++FeIXehUcaB1OPXY/AeveOb
 mRmfGsi20Ex/fH/8Z1kuCHBqXrQEPqLz8B3w34RzM0YxMa9SyieWoArFkvlXBKTMmIcDBo+9d
 W7whwBJtMUbcJ1fHuLkWlQp/5MZc4BBdnh/KTXcNsZRNzyi+mtYdgWIk5tjFjreGovw9r2mXM
 vE5RPF6R3S8RZ/odsG+gb8YS6J1dd8kjWFJ+nI1lNS7KpgMBZaDkYl4P5/tE8W/zpDNAFVDVK
 Ij/m1+8L6oRZyz1vpf85cnaYkdxLuPCdzVDZalDGplF+7lQ7fTqLJxJC9CPn5oX7jPU9ipkcJ
 JSl6gGyciS2n9phB06rYCBW2FkbuTFKitINg14xXskHJ1DIY/k43AySIfKuHdrGFBbR2/nO8X
 UofmvOprHc/9/QWx
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 02 January 2016 14:17:46 Mark Brown wrote:
> On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote:
> 
> > -             if (i2c_client->dev.of_node) {
> > +             if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {
> 
> This would be a lot nicer if there was an __always_null annotation we
> could put on of_node for !OF configurations, that'd Just Work and this
> can't be the only case where we have this idiom.
> 

How about an inline helper like

static inline struct device_node *dev_of_node(struct device *dev)
{
	if (IS_ENABLED(CONFIG_OF))
		return dev->of_node;	
}

	Arnd