From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: roman.stratiienko@globallogic.com
Cc: linux-kernel@vger.kernel.org, mripard@kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: drm/sun4i: Add missing pixel formats to the vi layer
Date: Thu, 19 Sep 2019 20:53:10 +0200 [thread overview]
Message-ID: <9229663.7SG9YZCNdo@jernej-laptop> (raw)
In-Reply-To: <20190918110541.38124-1-roman.stratiienko@globallogic.com>
Hi!
Dne sreda, 18. september 2019 ob 13:05:41 CEST je
roman.stratiienko@globallogic.com napisal(a):
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> According to Allwinner DE2.0 Specification REV 1.0, vi layer supports the
> following pixel formats: ABGR_8888, ARGB_8888, BGRA_8888, RGBA_8888
It's true that DE2 VI layers support those formats, but it wouldn't change
anything because alpha blending is not supported by those planes. These
formats were deliberately left out because their counterparts without alpha
exist, for example ABGR8888 <-> XBGR8888. It would also confuse user, which
would expect that alpha blending works if format with alpha channel is
selected.
Admittedly some formats with alpha are still reported as supported due to lack
of their counterparts without alpha, but I'm fine with removing them for
consistency.
Best regards,
Jernej
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> ---
> drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
> b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index bd0e6a52d1d8..07c27e6a4b77
> 100644
> --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
> @@ -404,17 +404,21 @@ static const struct drm_plane_funcs
> sun8i_vi_layer_funcs = { static const u32 sun8i_vi_layer_formats[] = {
> DRM_FORMAT_ABGR1555,
> DRM_FORMAT_ABGR4444,
> + DRM_FORMAT_ABGR8888,
> DRM_FORMAT_ARGB1555,
> DRM_FORMAT_ARGB4444,
> + DRM_FORMAT_ARGB8888,
> DRM_FORMAT_BGR565,
> DRM_FORMAT_BGR888,
> DRM_FORMAT_BGRA5551,
> DRM_FORMAT_BGRA4444,
> + DRM_FORMAT_BGRA8888,
> DRM_FORMAT_BGRX8888,
> DRM_FORMAT_RGB565,
> DRM_FORMAT_RGB888,
> DRM_FORMAT_RGBA4444,
> DRM_FORMAT_RGBA5551,
> + DRM_FORMAT_RGBA8888,
> DRM_FORMAT_RGBX8888,
> DRM_FORMAT_XBGR8888,
> DRM_FORMAT_XRGB8888,
next prev parent reply other threads:[~2019-09-19 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 11:05 [PATCH] drm/sun4i: Add missing pixel formats to the vi layer roman.stratiienko
2019-09-19 18:53 ` Jernej Škrabec [this message]
2019-09-20 6:20 ` Maxime Ripard
2019-09-20 10:14 ` Roman Stratiienko
2019-09-20 20:22 ` Roman Stratiienko
2019-09-20 20:31 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9229663.7SG9YZCNdo@jernej-laptop \
--to=jernej.skrabec@siol.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=roman.stratiienko@globallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).