From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: broonie@kernel.org, spapothi@codeaurora.org,
bgoswami@codeaurora.org, plai@codeaurora.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v2 3/4] ASoC: qdsp6: q6afe-dai: Update max rate for slim and tdm dais
Date: Thu, 22 Aug 2019 11:45:48 +0100 [thread overview]
Message-ID: <923f1d65-d908-c64c-3109-0da1938d3824@linaro.org> (raw)
In-Reply-To: <s5h7e75v7en.wl-tiwai@suse.de>
On 22/08/2019 11:09, Takashi Iwai wrote:
> On Thu, 22 Aug 2019 11:56:52 +0200,
> Srinivas Kandagatla wrote:
>>
>> QDSP supports up to 384000 rates on SLIM dais and 352800 rate on TDM dais.
>> Add this missing rates.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> sound/soc/qcom/qdsp6/q6afe-dai.c | 92 +++++++++++---------------------
>> 1 file changed, 32 insertions(+), 60 deletions(-)
>>
>> diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c
>> index c1a7624eaf17..ae2baefdb6e2 100644
>> --- a/sound/soc/qcom/qdsp6/q6afe-dai.c
>> +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c
>> @@ -18,14 +18,14 @@
>> .stream_name = pre" TDM"#num" Playback", \
>> .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
>> SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
>> - SNDRV_PCM_RATE_176400, \
>> + SNDRV_PCM_RATE_176400 | SNDRV_PCM_RATE_352800,\
>
> This will support a lot more than advertised, e.g. it contains 64000Hz
> or 22050Hz. Is this supposed? If yes, mention it clearly in the
> changelog, too.
Some of the rates inbetween are not in the DSP supported rate list for TDM.
DSP should return error if we try to set any unsupported rate!
--srini
>
> thanks,
>
> Takashi
>
next prev parent reply other threads:[~2019-08-22 10:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 9:56 [PATCH v2 0/4] ALSA: pcm: add support for 352.8KHz and 384KHz sample rate Srinivas Kandagatla
2019-08-22 9:56 ` [PATCH v2 1/4] " Srinivas Kandagatla
2019-08-22 10:12 ` Takashi Iwai
2019-08-28 13:13 ` Applied "ALSA: pcm: add support for 352.8KHz and 384KHz sample rate" to the asoc tree Mark Brown
2019-08-22 9:56 ` [PATCH v2 2/4] ASoC: wcd9335: Fix primary interpolator max rate Srinivas Kandagatla
2019-08-28 13:13 ` Applied "ASoC: wcd9335: Fix primary interpolator max rate" to the asoc tree Mark Brown
2019-08-22 9:56 ` [PATCH v2 3/4] ASoC: qdsp6: q6afe-dai: Update max rate for slim and tdm dais Srinivas Kandagatla
2019-08-22 10:09 ` Takashi Iwai
2019-08-22 10:45 ` Srinivas Kandagatla [this message]
2019-08-22 10:53 ` Mark Brown
2019-08-22 9:56 ` [PATCH v2 4/4] ASoC: qdsp6: q6asm-dai: fix max rates on q6asm dais Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=923f1d65-d908-c64c-3109-0da1938d3824@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=spapothi@codeaurora.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).