From: David Howells <dhowells@redhat.com>
To: Hawkins Jiawei <yin31149@gmail.com>
Cc: dhowells@redhat.com,
syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com,
Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel-mentees@lists.linuxfoundation.org,
paskripkin@gmail.com, skhan@linuxfoundation.org,
18801353760@163.com
Subject: Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg
Date: Mon, 22 Aug 2022 09:48:14 +0100 [thread overview]
Message-ID: <924818.1661158094@warthog.procyon.org.uk> (raw)
In-Reply-To: <20220821125751.4185-1-yin31149@gmail.com>
Hawkins Jiawei <yin31149@gmail.com> wrote:
> - if (mutex_lock_interruptible(&call->user_mutex) < 0)
> + if (mutex_lock_interruptible(&call->user_mutex) < 0) {
> + mutex_lock(&call->user_mutex);
Yeah, as Khalid points out that kind of makes the interruptible lock
pointless. Either rxrpc_send_data() needs to return a separate indication
that we returned without the lock held or it needs to always drop the lock on
error (at least for ERESTARTSYS/EINTR) which can be checked for higher up.
David
next prev parent reply other threads:[~2022-08-22 8:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 10:37 [syzbot] WARNING: bad unlock balance in rxrpc_do_sendmsg syzbot
2022-08-21 12:57 ` [PATCH] rxrpc: fix " Hawkins Jiawei
2022-08-21 15:58 ` Khalid Masum
2022-08-21 16:42 ` Khalid Masum
2022-08-22 5:19 ` Hawkins Jiawei
2022-08-21 19:17 ` [syzbot] WARNING: " Khalid Masum
2022-08-21 22:29 ` syzbot
2022-08-22 8:48 ` David Howells [this message]
2022-08-22 9:21 ` [PATCH] rxrpc: fix " David Howells
2022-08-22 11:29 ` Hawkins Jiawei
2022-08-22 11:29 ` Hawkins Jiawei
2022-08-22 13:04 ` Hawkins Jiawei
2022-08-22 13:44 ` Dan Carpenter
2022-08-22 13:55 ` Khalid Masum
2022-08-22 14:05 ` Dan Carpenter
2022-08-22 15:39 ` Hawkins Jiawei
2022-08-22 16:00 ` Khalid Masum
2022-08-22 14:24 ` [syzbot] WARNING: " David Howells
2022-08-22 15:45 ` David Howells
2022-08-22 16:23 ` syzbot
2022-08-24 16:30 ` Marc Dionne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=924818.1661158094@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=18801353760@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paskripkin@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yin31149@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).