From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756226AbcIGC3L (ORCPT ); Tue, 6 Sep 2016 22:29:11 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36423 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755409AbcIGC3H (ORCPT ); Tue, 6 Sep 2016 22:29:07 -0400 Subject: Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show To: David Miller References: <1473129009-20478-1-git-send-email-hejianet@gmail.com> <1473129009-20478-2-git-send-email-hejianet@gmail.com> <20160906.155757.924163804989771884.davem@davemloft.net> Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, vyasevich@gmail.com, nhorman@tuxdriver.com, steffen.klassert@secunet.com, herbert@gondor.apana.org.au From: hejianet Message-ID: <9249517a-7f04-3bd2-3bf0-4370f63aad3c@gmail.com> Date: Wed, 7 Sep 2016 10:29:04 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160906.155757.924163804989771884.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/16 6:57 AM, David Miller wrote: > From: Jia He > Date: Tue, 6 Sep 2016 10:30:04 +0800 > >> +#define MAX(a, b) ((u32)(a) >= (u32)(b) ? (a) : (b)) Thanks B.R. Jia > Please do not define private min/max macros, use the existing max_t() > or similar as needed. >