From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756465AbdKCTwS (ORCPT ); Fri, 3 Nov 2017 15:52:18 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:44544 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293AbdKCTwQ (ORCPT ); Fri, 3 Nov 2017 15:52:16 -0400 X-Google-Smtp-Source: ABhQp+Ro3gozoedw/zbjVFcSK+4Q8WvSWFPWmwR8srQVC4g7U8BTOjYLFFznKHSfQLv2nNtoVlVsMw== Subject: Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings To: Lipeng , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com References: <1509682710-94908-1-git-send-email-lipeng321@huawei.com> <1509682710-94908-5-git-send-email-lipeng321@huawei.com> From: Florian Fainelli Message-ID: <926ca4e8-78af-d442-38c5-bf38141051b5@gmail.com> Date: Fri, 3 Nov 2017 12:52:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1509682710-94908-5-git-send-email-lipeng321@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 09:18 PM, Lipeng wrote: > From: Fuyun Liang > > This patch adds set_link_ksettings support for ethtool cmd. > > Signed-off-by: Fuyun Liang > Signed-off-by: Lipeng > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c > index c7b8ebd..7fe193b 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c > @@ -653,6 +653,16 @@ static int hns3_get_link_ksettings(struct net_device *netdev, > return 0; > } > > +static int hns3_set_link_ksettings(struct net_device *netdev, > + const struct ethtool_link_ksettings *cmd) > +{ > + /* Only support ksettings_set for netdev with phy attached for now */ > + if (netdev->phydev) > + return phy_ethtool_ksettings_set(netdev->phydev, cmd); > + > + return -EOPNOTSUPP; Consider using phy_ethtool_get_link_ksettings() which already checks for netdev->phydev. -- Florian