From: Paolo Abeni <pabeni@redhat.com>
To: Colin Foster <colin.foster@in-advantage.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
UNGLinuxDriver@microchip.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary exposure of stats structures
Date: Tue, 22 Nov 2022 15:54:33 +0100 [thread overview]
Message-ID: <927643d6c2e5f681847fd2023ee2dab371ecba12.camel@redhat.com> (raw)
In-Reply-To: <20221119231406.3167852-3-colin.foster@in-advantage.com>
On Sat, 2022-11-19 at 15:14 -0800, Colin Foster wrote:
> Since commit 4d1d157fb6a4 ("net: mscc: ocelot: share the common stat
> definitions between all drivers") there is no longer a need to share the
> stats structures to the world. Relocate these definitions to inside
> ocelot_stats.c instead of a global include header.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
I think it's preferable to keep the moved code verbatim as-is instead
of additionally fixing the checkpatch warning in the same patch.
The mentioned cleanup could be a follow-up patch - togethar with the
trailing empty line removal.
Cheers,
Paolo
next prev parent reply other threads:[~2022-11-22 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 23:14 [PATCH v2 net-next 0/3] cleanup ocelot_stats exposure Colin Foster
2022-11-19 23:14 ` [PATCH v2 net-next 1/3] net: mscc: ocelot: remove redundant stats_layout pointers Colin Foster
2022-11-21 16:46 ` Vladimir Oltean
2022-11-19 23:14 ` [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary exposure of stats structures Colin Foster
2022-11-21 16:50 ` Vladimir Oltean
2022-11-22 14:54 ` Paolo Abeni [this message]
2022-11-19 23:14 ` [PATCH v2 net-next 3/3] net: mscc: ocelot: issue a warning if stats are incorrectly ordered Colin Foster
2022-11-21 16:51 ` Vladimir Oltean
2022-11-22 14:40 ` [PATCH v2 net-next 0/3] cleanup ocelot_stats exposure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927643d6c2e5f681847fd2023ee2dab371ecba12.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).