From: Joe Perches <joe@perches.com>
To: Slawomir Stepien <sst@poczta.fm>, Gabriel Capella <gabriel@capella.pro>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com,
apw@canonical.com
Subject: Re: [PATCH] staging: iio: adc: Add comments to prevent checks corrections
Date: Tue, 16 Oct 2018 11:16:46 -0700 [thread overview]
Message-ID: <928f615f2a25f821e785f2db96f90df009d2fa34.camel@perches.com> (raw)
In-Reply-To: <20181016180631.GA6085@x220.localdomain>
On Tue, 2018-10-16 at 20:06 +0200, Slawomir Stepien wrote:
> On paź 15, 2018 18:25, Gabriel Capella wrote:
> > This patch adds 3 comments in 2 different files.
> > These comments warn to don't correct the checks of type:
> > "CHECK: spaces preferred around that '-'"
> >
> > Signed-off-by: Gabriel Capella <gabriel@capella.pro>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 1 +
> > drivers/staging/iio/adc/ad7280a.c | 2 ++
> > 2 files changed, 3 insertions(+)
>
> I have this simpler solution...let's focus our efforts on moving the two drivers
> out of staging. This will prevent the CHK to appear:
>
> Cut from checkpatch.pl:
>
> if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) {
> $check = 1;
>
> Existing driver out of staging, with this "problem":
> $ ./scripts/checkpatch.pl --types SPACING --file drivers/iio/adc/ad7793.c
> total: 0 errors, 0 warnings, 827 lines checked
>
> drivers/iio/adc/ad7793.c has no obvious style problems and is ready for submission.
>
> NOTE: Used message types: SPACING
>
> In my opinion it would stop this incorrect patches. -
>
> I have also this changes to checkpatch.pl:
> https://github.com/s-stepien/linux-1/commit/c976a31b392393fb417f2d9e2ec9639bc226ad0b
> and usage:
> https://github.com/s-stepien/linux-1/commit/1adc0428b496f44f6a931637084bb619ddd9992d
> but I'm not that sure it is the best way to go.
>
> What do you all think?
I think the suggested form is somewhat cryptic
/* checkpatch-<foo> */
and the new checkpatch code is somewhat balky.
It also allows only a single type to ignore per line.
prev parent reply other threads:[~2018-10-16 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 21:25 [PATCH] staging: iio: adc: Add comments to prevent checks corrections Gabriel Capella
2018-10-16 12:44 ` Dan Carpenter
2018-10-16 18:06 ` Slawomir Stepien
2018-10-16 18:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=928f615f2a25f821e785f2db96f90df009d2fa34.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gabriel@capella.pro \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).