From: German Gomez <german.gomez@arm.com>
To: James Clark <james.clark@arm.com>,
coresight@lists.linaro.org, suzuki.poulose@arm.com
Cc: mathieu.poirier@linaro.org, mike.leach@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] coresight: Remove unused function parameter
Date: Mon, 25 Jul 2022 16:07:40 +0100 [thread overview]
Message-ID: <9292b1c9-25ab-1137-1a34-3783f3835f2b@arm.com> (raw)
In-Reply-To: <20220725145221.517776-2-james.clark@arm.com>
On 25/07/2022 15:52, James Clark wrote:
> The ability to use a custom function in this sysfs show function isn't
> used so remove it.
>
> No functional changes.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-priv.h | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index ff1dd2092ac5..f2458b794ef3 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -40,31 +40,23 @@
> #define ETM_MODE_EXCL_KERN BIT(30)
> #define ETM_MODE_EXCL_USER BIT(31)
>
> -typedef u32 (*coresight_read_fn)(const struct device *, u32 offset);
> -#define __coresight_simple_func(type, func, name, lo_off, hi_off) \
> +#define __coresight_simple_show(type, name, lo_off, hi_off) \
> static ssize_t name##_show(struct device *_dev, \
> struct device_attribute *attr, char *buf) \
> { \
> type *drvdata = dev_get_drvdata(_dev->parent); \
> - coresight_read_fn fn = func; \
> u64 val; \
> pm_runtime_get_sync(_dev->parent); \
> - if (fn) \
> - val = (u64)fn(_dev->parent, lo_off); \
> - else \
> - val = coresight_read_reg_pair(drvdata->base, \
> - lo_off, hi_off); \
> + val = coresight_read_reg_pair(drvdata->base, lo_off, hi_off); \
> pm_runtime_put_sync(_dev->parent); \
> return scnprintf(buf, PAGE_SIZE, "0x%llx\n", val); \
Sorry for the slightly out-of-scope reply, but I think you could also
take the opportunity to replace scnprintf() calls with sysfs_emit()
calls, if you think it is worth it.
Thanks,
German
> } \
> static DEVICE_ATTR_RO(name)
>
> -#define coresight_simple_func(type, func, name, offset) \
> - __coresight_simple_func(type, func, name, offset, -1)
> #define coresight_simple_reg32(type, name, offset) \
> - __coresight_simple_func(type, NULL, name, offset, -1)
> + __coresight_simple_show(type, name, offset, -1)
> #define coresight_simple_reg64(type, name, lo_off, hi_off) \
> - __coresight_simple_func(type, NULL, name, lo_off, hi_off)
> + __coresight_simple_show(type, name, lo_off, hi_off)
>
> extern const u32 coresight_barrier_pkt[4];
> #define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt))
next prev parent reply other threads:[~2022-07-25 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 14:52 [PATCH v1 0/4] coresight: Reduce duplicated sysfs accessors James Clark
2022-07-25 14:52 ` [PATCH v1 1/4] coresight: Remove unused function parameter James Clark
2022-07-25 15:07 ` German Gomez [this message]
2022-07-25 14:52 ` [PATCH v1 2/4] coresight: Simplify sysfs accessors by using csdev_access abstraction James Clark
2022-08-22 17:37 ` Mathieu Poirier
2022-08-23 12:28 ` James Clark
2022-08-25 16:54 ` Mathieu Poirier
2022-07-25 14:52 ` [PATCH v1 3/4] coresight: Re-use same function for similar sysfs register accessors James Clark
2022-08-22 17:43 ` Mathieu Poirier
2022-07-25 14:52 ` [PATCH v1 4/4] coresight: cti-sysfs: Re-use same functions " James Clark
2022-08-22 17:45 ` [PATCH v1 0/4] coresight: Reduce duplicated sysfs accessors Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9292b1c9-25ab-1137-1a34-3783f3835f2b@arm.com \
--to=german.gomez@arm.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).