From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbcLHQAG (ORCPT ); Thu, 8 Dec 2016 11:00:06 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:1070 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbcLHQAF (ORCPT ); Thu, 8 Dec 2016 11:00:05 -0500 Subject: Re: [PATCH net-next 0/2] Initial driver for Synopsys DWC XLGMAC To: Jie Deng , , , References: CC: , , , From: Alexandre Torgue Message-ID: <92a2dbaf-00be-bded-aa75-4c920db4a204@st.com> Date: Thu, 8 Dec 2016 16:59:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.0.2] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-08_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 12/07/2016 04:57 AM, Jie Deng wrote: > This series provides the support for 25/40/50/100 GbE > devices using Synopsys DWC Enterprise Ethernet (XLGMAC). Can you explain which GMAC are you targeted ? A driver which support some Synopsys GMAC IP already exists. It support GMAC 3.5, 3.7, 4.0, 4.10 versions. You can find it in: drivers/net/ethernet/stmicro/stmmac/. When I look at all files your gonna to create, it looks like to ones in stmmac driver so maybe you could easily add your IP inside stmmac driver. Note that an other driver is existing for synopsys GMAC 4.0 IP. it is located in drivers/net/ethernet/synopsys/dwc_eth_qos.c and coming from AXIS guys. A task is ongoing to only have stmmac driver so it should be harmful to create a new one. Regards Alex > > The first patch adds support for Synopsys XLGMII. > The second patch provides the initial driver for Synopsys XLGMAC > > The driver has three layers by refactoring AMD XGBE. > > dwc-eth-xxx.x > The DWC ethernet core layer (DWC ECL). This layer contains codes > can be shared by different DWC series ethernet cores > > dwc-xxx.x (e.g. dwc-xlgmac.c) > The DWC MAC HW adapter layer (DWC MHAL). This layer contains > special support for a specific MAC. e.g. currently, XLGMAC. > > xxx-xxx-pci.c xxx-xxx-plat.c (e.g. dwc-xlgmac-pci.c) > The glue adapter layer (GAL). Vendors who adopt Synopsys Etherent > cores can develop a glue driver for their platform. > > Jie Deng (2): > net: phy: add extension of phy-mode for XLGMII > net: ethernet: Initial driver for Synopsys DWC XLGMAC > > Documentation/devicetree/bindings/net/ethernet.txt | 1 + > MAINTAINERS | 6 + > drivers/net/ethernet/synopsys/Kconfig | 2 + > drivers/net/ethernet/synopsys/Makefile | 1 + > drivers/net/ethernet/synopsys/dwc/Kconfig | 37 + > drivers/net/ethernet/synopsys/dwc/Makefile | 9 + > drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c | 228 ++ > .../net/ethernet/synopsys/dwc/dwc-eth-debugfs.c | 328 +++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c | 715 +++++ > .../net/ethernet/synopsys/dwc/dwc-eth-ethtool.c | 567 ++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c | 3098 ++++++++++++++++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c | 252 ++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c | 2319 +++++++++++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c | 216 ++ > drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h | 1115 +++++++ > drivers/net/ethernet/synopsys/dwc/dwc-eth.h | 738 +++++ > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c | 538 ++++ > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c | 135 + > drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h | 85 + > include/linux/phy.h | 3 + > 20 files changed, 10393 insertions(+) > create mode 100644 drivers/net/ethernet/synopsys/dwc/Kconfig > create mode 100644 drivers/net/ethernet/synopsys/dwc/Makefile > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-dcb.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-debugfs.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-desc.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ethtool.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-hw.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-mdio.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-net.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-ptp.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth-regacc.h > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-eth.h > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac-pci.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.c > create mode 100644 drivers/net/ethernet/synopsys/dwc/dwc-xlgmac.h >