From: Ian Abbott <abbotti@mev.co.uk>
To: Tong Zhang <ztong0001@gmail.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
devel@driverdev.osuosl.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: replace slash in name
Date: Tue, 16 Mar 2021 10:37:47 +0000 [thread overview]
Message-ID: <92b7c57b-b645-9965-8157-4ca76a803cba@mev.co.uk> (raw)
In-Reply-To: <CAA5qM4AJRYndkXSiW5Y4OCFcH97mf6UiiEEox+TQs8-N957mJA@mail.gmail.com>
On 15/03/2021 20:00, Tong Zhang wrote:
> Thanks Ian,
> I have submitted a v2 patch based on your suggestions.
> Thanks,
> - Tong
Thanks. I think the only other Comedi driver with the same problem is
"drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as
the name argument of request_irq(), but that is "cio-das802/16" for one
of the boards supported by the driver.
> On Mon, Mar 15, 2021 at 6:48 AM Ian Abbott <abbotti@mev.co.uk> wrote:
>>
>> On 15/03/2021 10:44, Ian Abbott wrote:
>>> On 14/03/2021 03:57, Tong Zhang wrote:
>>>> request_irq() wont accept a name which contains slash so we need to
>>>> repalce it with something else -- otherwise it will trigger a warning
>>>> and the entry in /proc/irq/ will not be created
>>>>
>>>> [ 1.565966] name 'pci-das6402/16'
>>>> [ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0
>>>> [ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0
>>>> [ 1.574200] Call Trace:
>>>> [ 1.574722] proc_mkdir+0x18/0x20
>>>> [ 1.576629] request_threaded_irq+0xfe/0x160
>>>> [ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64]
>>>>
>>>> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
>> [snip]
>>> Userspace applications can use these strings to determine the board
>>> type, so changing the strings would break those applications.
>>>
>>> I suggest passing the comedi driver name "cb_pcidas" to request_irq()
>>> for now.
>>
>> Oops, I meant "cb_pcidas64". But you could reach that via
>> dev->driver->driver_name if you want (where dev is the struct
>> comedi_device * parameter).
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
next prev parent reply other threads:[~2021-03-16 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 3:57 [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-15 10:44 ` Ian Abbott
2021-03-15 10:48 ` Ian Abbott
2021-03-15 19:58 ` [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn Tong Zhang
2021-03-16 10:31 ` Ian Abbott
2021-03-15 20:00 ` [PATCH] staging: comedi: replace slash in name Tong Zhang
2021-03-16 10:37 ` Ian Abbott [this message]
2021-03-16 22:42 ` [PATCH] staging: comedi: das800: fix request_irq() warn Tong Zhang
2021-03-17 5:14 ` Dan Carpenter
[not found] ` <CAA5qM4BcQ6+aa1C3_28zLVojwLduK-WZwsEftuasJgo8z0t0ew@mail.gmail.com>
2021-03-17 6:52 ` Dan Carpenter
2021-03-17 22:43 ` Tong Zhang
2021-03-17 12:48 ` Ian Abbott
2021-03-19 3:47 ` [PATCH v2] " Tong Zhang
2021-03-19 3:48 ` [PATCH] " Tong Zhang
2021-03-16 22:42 ` [PATCH] staging: comedi: replace slash in name Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b7c57b-b645-9965-8157-4ca76a803cba@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).