From: Randy Dunlap <rdunlap@infradead.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-media@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>
Subject: Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support
Date: Thu, 6 Jun 2019 16:10:30 -0700 [thread overview]
Message-ID: <92ca6e6e-2ebd-cec4-4f75-2674fd2c3d99@infradead.org> (raw)
In-Reply-To: <20190606153825.8183-2-sebastien.szymanski@armadeus.com>
On 6/6/19 8:38 AM, Sébastien Szymanski wrote:
> i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support
> to imx7-media-csi driver.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>
> Changes for v2:
> - rebase on top of linuxtv/master
> - mention i.MX6UL/L in header and Kconfig help text
> - rename csi_type to csi_soc_id
>
> drivers/staging/media/imx/Kconfig | 4 +-
> drivers/staging/media/imx/imx7-media-csi.c | 62 ++++++++++++++++------
> 2 files changed, 49 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index ad3d7df6bb3c..8b6dc42c39e0 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -22,11 +22,11 @@ config VIDEO_IMX_CSI
> A video4linux camera sensor interface driver for i.MX5/6.
>
> config VIDEO_IMX7_CSI
> - tristate "i.MX7 Camera Sensor Interface driver"
> + tristate "i.MX6UL/L / i.MX7 Camera Sensor Interface driver"
> depends on VIDEO_IMX_MEDIA && VIDEO_DEV && I2C
> default y
Hi,
I realize that this "default y" is not part of this patch set, but we have
pretty strong guidance that a driver should not default to 'y' unless it is
needed for a system to boot. If this driver is optional, then please drop
the 2 occurrences of "default y" in this Kconfig file.
thanks.
> help
> Enable support for video4linux camera sensor interface driver for
> - i.MX7.
> + i.MX6UL/L or i.MX7.
> endmenu
> endif
--
~Randy
next prev parent reply other threads:[~2019-06-06 23:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 15:38 [PATCH v2 1/3] ARM: dts: imx6ul: Add csi node Sébastien Szymanski
2019-06-06 15:38 ` [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support Sébastien Szymanski
2019-06-06 23:10 ` Randy Dunlap [this message]
2019-06-10 10:32 ` Rui Miguel Silva
2019-06-10 10:28 ` Rui Miguel Silva
2019-06-11 8:16 ` Sébastien Szymanski
2019-06-11 9:40 ` Rui Miguel Silva
2019-06-11 10:03 ` Sébastien Szymanski
2019-06-11 11:56 ` Rui Miguel Silva
2019-06-06 15:38 ` [PATCH v2 3/3] media: dt-bindings: imx7-csi: add i.MX6UL/L support Sébastien Szymanski
2019-07-09 1:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92ca6e6e-2ebd-cec4-4f75-2674fd2c3d99@infradead.org \
--to=rdunlap@infradead.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastien.szymanski@armadeus.com \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).