From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753416AbdLVLuw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Dec 2017 06:50:52 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36234 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751733AbdLVLuu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Dec 2017 06:50:50 -0500
X-Google-Smtp-Source: ACJfBovNjvpRbj9vkBRR24c2aON3yBGRmcfshu2K+uvKtPPitHBLrcM629Igb3q55Bq6BlmwIsSLlA==
Subject: Re: [PATCH] drm: fix tainted kernel caused by
 drm_panel_orientation_quirks.c
To: David Lechner <david@lechnology.com>, dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@intel.com>,
        Gustavo Padovan <gustavo@padovan.org>,
        Sean Paul <seanpaul@chromium.org>, David Airlie <airlied@linux.ie>,
        linux-kernel@vger.kernel.org
References: <1513881979-13801-1-git-send-email-david@lechnology.com>
From: Hans de Goede <j.w.r.degoede@gmail.com>
Message-ID: <92cad55e-f225-2ae0-a091-a03b40c3a98d@gmail.com>
Date: Fri, 22 Dec 2017 12:50:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1513881979-13801-1-git-send-email-david@lechnology.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
> 
> Signed-off-by: David Lechner <david@lechnology.com>

Thank you for taking care of this, looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
>    */
>   
>   #include <linux/dmi.h>
> +#include <linux/module.h>
>   #include <drm/drm_connector.h>
>   
>   #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
>   EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>   
>   #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
>