From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: allow building the clkout driver as module
Date: Thu, 12 Nov 2020 15:36:35 +0100 [thread overview]
Message-ID: <92ccc476-6afd-4be9-7c72-40c9a9218b03@kernel.org> (raw)
In-Reply-To: <20201110193749.261367-1-krzk@kernel.org>
On 11/10/20 20:37, Krzysztof Kozlowski wrote:
> The Exynos clock output driver can be built as module (it does not have
> to be part of core init process) for better customization. Adding a
> KConfig entry allows also compile testing for build coverage.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
This needs to go through your tree due to dependencies on your previous
patches, so
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> drivers/clk/samsung/Kconfig | 10 ++++++++++
> drivers/clk/samsung/Makefile | 2 +-
> drivers/clk/samsung/clk-exynos-clkout.c | 1 +
> 3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
> index 57d4b3f20417..b6b2cb209543 100644
> --- a/drivers/clk/samsung/Kconfig
> +++ b/drivers/clk/samsung/Kconfig
> @@ -19,6 +19,16 @@ config EXYNOS_AUDSS_CLK_CON
> on some Exynos SoC variants. Choose M or Y here if you want to
> use audio devices such as I2S, PCM, etc.
>
> +config EXYNOS_CLK_OUT
Perhaps change it EXYNOS_CLKOUT for a better match with the SoC documentation?
> + tristate "Samsung Exynos clock output driver"
> + depends on COMMON_CLK_SAMSUNG
> + default y if ARCH_EXYNOS
> + help
> + Support for the clock output (XCLKOUT) driver present on some of
> + Exynos SoC variants. Usually the XCLKOUT is used to monitor the
> + status of the certains clocks from SoC, but it could also be tied to
> + other devices as an input clock.
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 1a4e6b787978..4adbf972e9f6 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o
> obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o
> obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o
> obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o
> -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o
> +obj-$(CONFIG_EXYNOS_CLK_OUT) += clk-exynos-clkout.o
--
Regards,
Sylwester
next prev parent reply other threads:[~2020-11-12 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201110193800epcas1p22bc64cad38fe355f25684175d2c77e83@epcas1p2.samsung.com>
2020-11-10 19:37 ` [PATCH] clk: samsung: allow building the clkout driver as module Krzysztof Kozlowski
2020-11-11 10:25 ` Chanwoo Choi
2020-11-12 14:36 ` Sylwester Nawrocki [this message]
2020-11-12 16:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92ccc476-6afd-4be9-7c72-40c9a9218b03@kernel.org \
--to=snawrocki@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).