From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF43C43142 for ; Wed, 27 Jun 2018 13:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B976126351 for ; Wed, 27 Jun 2018 13:22:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B976126351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546AbeF0NWN (ORCPT ); Wed, 27 Jun 2018 09:22:13 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45234 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752817AbeF0NWL (ORCPT ); Wed, 27 Jun 2018 09:22:11 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5RDJKxY165447 for ; Wed, 27 Jun 2018 09:22:11 -0400 Received: from e12.ny.us.ibm.com (e12.ny.us.ibm.com [129.33.205.202]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jv9yym87n-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 27 Jun 2018 09:22:10 -0400 Received: from localhost by e12.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Jun 2018 09:22:09 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e12.ny.us.ibm.com (146.89.104.199) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 27 Jun 2018 09:22:05 -0400 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5RDM4X97930364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 Jun 2018 13:22:04 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85D78112063; Wed, 27 Jun 2018 09:21:59 -0400 (EDT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71D46112061; Wed, 27 Jun 2018 09:21:59 -0400 (EDT) Received: from [9.56.58.136] (unknown [9.56.58.136]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 27 Jun 2018 09:21:59 -0400 (EDT) Subject: Re: [PATCH v3 0/2] Detect & register virtio-crypto algos only if it can be supported by backend To: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: qemu-devel@nongnu.org, herbert@gondor.apana.org.au, borntraeger@de.ibm.com, arei.gonglei@huawei.com, longpeng2@huawei.com, pasic@linux.ibm.com, frankja@linux.ibm.com, jasowang@redhat.com, mst@redhat.com, Farhan Ali References: From: Farhan Ali Date: Wed, 27 Jun 2018 09:22:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18062713-0060-0000-0000-000002833FA6 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009263; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01053073; UDB=6.00539911; IPR=6.00830997; MB=3.00021878; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-27 13:22:08 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062713-0061-0000-0000-00004597E0F7 Message-Id: <92d562ad-9533-48c4-53b7-d7dd8e383a79@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-27_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806270146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Polite ping :) Would like to know how to merge these patches in the mainline kernel. Thanks Farhan On 06/19/2018 11:41 AM, Farhan Ali wrote: > Hi, > > Currently the Linux virtio-crypto driver registers the crypto > algorithm without verifying if the backend actually supports the > algorithm. > > This kernel patch series adds support for registering algorithm > with Linux crypto layer, only if the algorithm is supported by > the backend device. This also makes the driver more compliant with > the virtio-crypto spec [1]. > > I would appreciate any feedback or comments on this. > > Thank you > Farhan > > Reference > --------- > [1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html > > ChangeLog > --------- > v2 -> v3 > - Add Christian Borntrager's acks for the patches. > > v1 -> v2 > - Modify comment as suggested by Arei (patch 1) > - Modify error message as suggested by Arei (patch 2) > > Farhan Ali (2): > crypto/virtio-crypto: Read crypto services and algorithm masks > crypto/virtio-crypto: Register an algo only if it's supported > > drivers/crypto/virtio/virtio_crypto_algs.c | 112 ++++++++++++++++++--------- > drivers/crypto/virtio/virtio_crypto_common.h | 25 +++++- > drivers/crypto/virtio/virtio_crypto_core.c | 29 +++++++ > drivers/crypto/virtio/virtio_crypto_mgr.c | 81 +++++++++++++++++-- > 4 files changed, 202 insertions(+), 45 deletions(-) >