From: Edward Cree <ecree@solarflare.com>
To: David Miller <davem@davemloft.net>, <luobin9@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<luoxianjun@huawei.com>, <yin.yinshi@huawei.com>,
<cloud.wangxiaoyun@huawei.com>, <chiqijun@huawei.com>
Subject: Re: [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event
Date: Fri, 24 Jul 2020 10:57:30 +0100 [thread overview]
Message-ID: <92dac9af-8623-bd1e-7a4d-9d12671699ad@solarflare.com> (raw)
In-Reply-To: <20200723.120852.1882569285026023193.davem@davemloft.net>
On 23/07/2020 20:08, David Miller wrote:
> From: Luo bin <luobin9@huawei.com>
> Date: Thu, 23 Jul 2020 22:40:37 +0800
>
>> +static int hinic_fw_reporter_dump(struct devlink_health_reporter *reporter,
>> + struct devlink_fmsg *fmsg, void *priv_ctx,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct hinic_mgmt_watchdog_info *watchdog_info;
>> + int err;
>> +
>> + if (priv_ctx) {
>> + watchdog_info = priv_ctx;
>> + err = mgmt_watchdog_report_show(fmsg, watchdog_info);
>> + if (err)
>> + return err;
>> + }
>> +
>> + return 0;
>> +}
> This 'watchdog_info' variable is completely unnecessary, just pass
> 'priv_ctx' as-is into mgmt_watchdog_report_show().
Looks like the 'err' variable is unnecessary too...
-ed
next prev parent reply other threads:[~2020-07-24 9:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 14:40 [PATCH net-next v3 0/2] hinic: add some error messages for debug Luo bin
2020-07-23 14:40 ` [PATCH net-next v3 1/2] hinic: add support to handle hw abnormal event Luo bin
2020-07-23 19:08 ` David Miller
2020-07-24 0:58 ` luobin (L)
2020-07-24 9:57 ` Edward Cree [this message]
2020-07-25 1:19 ` luobin (L)
2020-07-23 14:40 ` [PATCH net-next v3 2/2] hinic: add log in exception handling processes Luo bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92dac9af-8623-bd1e-7a4d-9d12671699ad@solarflare.com \
--to=ecree@solarflare.com \
--cc=chiqijun@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luobin9@huawei.com \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).