From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AD3C33C9E for ; Tue, 7 Jan 2020 18:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBE6C20848 for ; Tue, 7 Jan 2020 18:47:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="evL9Ec0j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728607AbgAGSrX (ORCPT ); Tue, 7 Jan 2020 13:47:23 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27793 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728412AbgAGSrX (ORCPT ); Tue, 7 Jan 2020 13:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578422842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/8Zg9nxAOoXcvew8mYe1pYf5ie2kAu84kdP/XsWGT2E=; b=evL9Ec0jCdrYkz/wiUpctRTYm4sHGbiR6ISoe7gGguchU1pM6TbZshjU7YmuTYWbTz5iPE voW0xPjbQ3icBr7tLLZ4jiPf4H+Rrvi/AJVyQ5oEhTqsfZ2jdoMFIWyvAGng9fEp7b/Wf1 p5l5VMLRiR5lkNECfiblm2sK6mGLljQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-5P3zQb2kMJqpMLGs2uRfug-1; Tue, 07 Jan 2020 13:47:21 -0500 X-MC-Unique: 5P3zQb2kMJqpMLGs2uRfug-1 Received: by mail-wr1-f71.google.com with SMTP id z10so308349wrt.21 for ; Tue, 07 Jan 2020 10:47:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/8Zg9nxAOoXcvew8mYe1pYf5ie2kAu84kdP/XsWGT2E=; b=FBNuPlLML54O471ftT2Wp1WEBblZ7HZkreae547Ow5sgazHMt57UoxQH9lIq3BSdGX 9761gsYKLhgg0pQKZYF4I2V7+fSta8FCuW4oGOYlwo3RF5ia0JsUmjoefty3yuTBNwkF mwyztTtNsbQHErC5KxE70a0nYRE0tgbxtPtQRb3mN62Fy4mvZR2CGnQVcA1CBAvFHAIM rJR1gFaNWNzVfoarQtdHZwvONHsom37N/yNQ68+GF9ofOmDf2ZrgU+naajsv/mmiyHJ+ bXkWFxT0QQVqllrr6+7bldI8IzIFElJzFWjHo6QFlgMI8nlyCSb2nH7DWRsSdRfHhKim WuUg== X-Gm-Message-State: APjAAAWN+27KFN6tUfua0sKYDrMsklGGRHfcb2NP4Wrgdr4UBUgLw+/b 8pTEcSmBM7OuJucD3l9kgdtO4dyUZLSgcr8PsVS4SS8scMlCZTYXOb+aw7tjpDLWKq85xFwaO4+ I09OYSSjaDqb/kdMbK0b9g+Gw X-Received: by 2002:a1c:9acf:: with SMTP id c198mr374944wme.175.1578422840003; Tue, 07 Jan 2020 10:47:20 -0800 (PST) X-Google-Smtp-Source: APXvYqyS3CiETVxrLdyEhHA7cbzJ+/9zPZi9ioE/EmeP9k2qsD3wfuMIgZsc4+ZCakmbQ2rVRvEZ3w== X-Received: by 2002:a1c:9acf:: with SMTP id c198mr374926wme.175.1578422839831; Tue, 07 Jan 2020 10:47:19 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id p17sm956544wrx.20.2020.01.07.10.47.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 10:47:19 -0800 (PST) Subject: Re: [PATCH v3 0/3] ata: ahci_brcm: Follow-up changes for BCM7216 To: Florian Fainelli , linux-kernel@vger.kernel.org Cc: bcm-kernel-feedback-list@broadcom.com, Jens Axboe , Rob Herring , Mark Rutland , Philipp Zabel , Tejun Heo , Jaedon Shin , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20200107183022.26224-1-f.fainelli@gmail.com> From: Hans de Goede Message-ID: <92eeb7d0-5e96-b0b6-38db-a22d4862d6dd@redhat.com> Date: Tue, 7 Jan 2020 19:47:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200107183022.26224-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07-01-2020 19:30, Florian Fainelli wrote: > Hi Jens, Philipp, > > These three patches are a follow-up to my previous series titled: ata: > ahci_brcm: Fixes and new device support. > > After submitting the BCM7216 RESCAL reset driver, Philipp the reset > controller maintained indicated that the reset line should be self > de-asserting and so reset_control_reset() should be used instead. > > These three patches update the driver in that regard. It would be great if > you could apply those and get them queued up for 5.6 since they are > directly related to the previous series. > > Changes in v3: > - introduced a preliminary patch making use of the proper reset control > API in order to manage the optional reset controller line > - updated patches after introducing that preliminary patch > > Changes in v2: > - updated error path after moving the reset line control Series looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > Thanks! > > Florian Fainelli (3): > ata: ahci_brcm: Correct reset control API usage > ata: ahci_brcm: Perform reset after obtaining resources > ata: ahci_brcm: BCM7216 reset is self de-asserting > > drivers/ata/ahci_brcm.c | 42 +++++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 16 deletions(-) >