From: Joe Perches <joe@perches.com>
To: Colin Ian King <colin.king@canonical.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller
Date: Thu, 19 Aug 2021 08:10:23 -0700 [thread overview]
Message-ID: <930fbf0e3b17a78c64a32d26fcf9aed46c5d6d88.camel@perches.com> (raw)
In-Reply-To: <c4378876-74b0-4f80-05b7-dcd809bb47a1@canonical.com>
On Thu, 2021-08-19 at 15:51 +0100, Colin Ian King wrote:
> it still makes sense for these kind of
> janitorial changes as it makes sense to constify arrays when they are
> read-only and making them static is sensible for const data.
I'm not disagreeing. Marking unmodifiable arrays as const is generally
useful for readers. Decent compilers though can _mostly_ determine
whether or not an array is used as const and whether the array can be
placed in a readonly section and is not required to be in a writable one.
But the object sizes deltas you show with an allmodconfig are misleading.
At a minimum I think you should show the output sizes as allmodconfig.
prev parent reply other threads:[~2021-08-19 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:38 [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller Colin King
2021-08-19 13:51 ` Joe Perches
2021-08-19 13:54 ` Colin Ian King
2021-08-19 14:40 ` Joe Perches
2021-08-19 14:51 ` Colin Ian King
2021-08-19 15:10 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=930fbf0e3b17a78c64a32d26fcf9aed46c5d6d88.camel@perches.com \
--to=joe@perches.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).