From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: Sort Pioneer model in blacklist names lexicographically
Date: Wed, 7 Dec 2022 16:30:15 +0100 [thread overview]
Message-ID: <9316beaf-2e7c-3a9f-a804-a1bda5a40241@molgen.mpg.de> (raw)
In-Reply-To: <7ee6b490-baa7-44f5-733d-528755f37d81@opensource.wdc.com>
Dear Damien,
Am 07.12.22 um 16:15 schrieb Damien Le Moal:
> On 12/7/22 22:26, Paul Menzel wrote:
>> Am 07.12.22 um 14:22 schrieb Damien Le Moal:
>>> On 12/7/22 19:26, Paul Menzel wrote:
>>>> Fixes: commit ea08aec7e77b ("libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205")
>>>> Cc: Niklas Cassel <niklas.cassel@wdc.com>
>>>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>>> ---
>>>> drivers/ata/libata-core.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>>>> index d3ce5c383f3a..c08c534b7fc7 100644
>>>> --- a/drivers/ata/libata-core.c
>>>> +++ b/drivers/ata/libata-core.c
>>>> @@ -3990,8 +3990,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>>> { "PIONEER DVD-RW DVR-216D", NULL, ATA_HORKAGE_NOSETXFER },
>>>>
>>>> /* These specific Pioneer models have LPM issues */
>>>> - { "PIONEER BD-RW BDR-207M", NULL, ATA_HORKAGE_NOLPM },
>>>> { "PIONEER BD-RW BDR-205", NULL, ATA_HORKAGE_NOLPM },
>>>> + { "PIONEER BD-RW BDR-207M", NULL, ATA_HORKAGE_NOLPM },
>>>
>>> Nah... Not worse the trouble. If anything, I would rather have the entire
>>> ata_device_blacklist array entries sorted alphabetically by vendor and models.
>>
>> What trouble?
>
> Manner of speaking. I meant the patch value is not worth the time to
> process it.
> As suggested, sorting the entire array would be a more valuable change.
Understood. (I guess perfect is the enemy of the good – also as seen
with my other patch from which other users can’t benefit.) :/
>>>> /* Crucial BX100 SSD 500GB has broken LPM support */
>>>> { "CT500BX100SSD1", NULL, ATA_HORKAGE_NOLPM },
Kind regards,
Paul
prev parent reply other threads:[~2022-12-07 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 10:26 [PATCH] libata: Sort Pioneer model in blacklist names lexicographically Paul Menzel
2022-12-07 13:22 ` Damien Le Moal
2022-12-07 13:26 ` Paul Menzel
2022-12-07 15:15 ` Damien Le Moal
2022-12-07 15:30 ` Paul Menzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9316beaf-2e7c-3a9f-a804-a1bda5a40241@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.cassel@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).