From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3422FC6182 for ; Fri, 14 Sep 2018 11:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DBCD20881 for ; Fri, 14 Sep 2018 11:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DNoCGumG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DBCD20881 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbeINQZC (ORCPT ); Fri, 14 Sep 2018 12:25:02 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34780 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbeINQZC (ORCPT ); Fri, 14 Sep 2018 12:25:02 -0400 Received: from avalon.localnet (unknown [IPv6:2a02:a03f:44f6:3500:d929:375b:d608:66c7]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C6119CE; Fri, 14 Sep 2018 13:10:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1536923459; bh=077zV60B+At60Es8WN0B+Sp8TWiPgKQmcp8PGR3Sn28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DNoCGumGnE5H/botUiAsZt9eBWeNxbkgD/7u8LnF0qlXpYLT5NTNGvE//GeoOnN5P jRyZuvv7hWHkGZ7GGImZQWJuBBrxY0mGriGih2B4kAwhoPbYKzWmA/MXFW+W4kDbYw s6uZ+QG4C2osYYJNluqYN9/YsNY4NsZofVMwwlG8= From: Laurent Pinchart To: Kieran Bingham Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Koji Matsuoka Subject: Re: [PATCH 2/3] drm: rcar-du: Add pixel format support Date: Fri, 14 Sep 2018 14:11:13 +0300 Message-ID: <9318122.8LJjaKzHaP@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180831181259.29529-3-kieran.bingham+renesas@ideasonboard.com> References: <20180831181259.29529-1-kieran.bingham+renesas@ideasonboard.com> <20180831181259.29529-3-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kieran, Thank you for the patch. How about renaming the subject line to "Add support for missing pixel formats" ? On Friday, 31 August 2018 21:12:58 EEST Kieran Bingham wrote: > From: Koji Matsuoka > > This patch supports pixel format of RGB332, ARGB4444, XRGB4444, > BGR888, RGB888, BGRA8888, BGRX8888 and YVYU. > VYUY pixel format is not supported by H/W specification. > > Signed-off-by: Koji Matsuoka > Signed-off-by: Kieran Bingham > > --- > > This patch does not remove existing support for multiplanar YVUY, even > though the hardware does not explicitly provide it, because we support > it through software by swapping the plane buffers. > > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 32 +++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index 7c7aff8cdf77..d1bd174ec893 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -124,6 +124,38 @@ static const struct rcar_du_format_info > rcar_du_format_infos[] = { .fourcc = DRM_FORMAT_YVU444, > .bpp = 24, > .planes = 3, > + }, { > + .fourcc = DRM_FORMAT_RGB332, > + .bpp = 8, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_ARGB4444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_XRGB4444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGR888, > + .bpp = 24, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_RGB888, > + .bpp = 24, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRA8888, > + .bpp = 32, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRX8888, > + .bpp = 32, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_YVYU, > + .bpp = 16, > + .planes = 1, > }, > }; I would list the RGB formats first, followed by the packed YUV format, and then the multiplanar YUV formats. With this changed, Reviewed-by: Laurent Pinchart If you're fine with the changes there's no need to resubmit. -- Regards, Laurent Pinchart