From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE193C64EC4 for ; Wed, 8 Mar 2023 11:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231283AbjCHLPl (ORCPT ); Wed, 8 Mar 2023 06:15:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbjCHLPf (ORCPT ); Wed, 8 Mar 2023 06:15:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E99F5C10F; Wed, 8 Mar 2023 03:15:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4579BB81B29; Wed, 8 Mar 2023 11:15:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7255C433D2; Wed, 8 Mar 2023 11:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678274131; bh=Xc836AV3aZd6hwPzbcQAAbiJjvAN+j1p/M2fEpvZ/UI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NJ3VGXNCaBkpUmsG5wjJTM9WBY40XZJIzfaTOpdgShqvWojmxWSMVS+sQg4DVhvbl wlYluIfwEYdiYrRA0u9PYpvI4l3u1N7iB9PR7kIrUcWvhjXgYHgmwXvhgHjqvd7Scl KwqCzgOQGqox6YYol5Rzb9asqL4eCgr1u6q4mHJYOpFXOVkdNElZxUAgHT2TlSOe2H ZQHEMaj2vZ6o5kUH/ARWGTLjll/OR/UetEDIedZ0R+y85zE3/yqukQByKhyM7OkCPX kiTzP4Xqf45mioY92i1fg4Gs172zEAsRrA3ugQw8HNA0aaqBKYcQ9w966J0yyrdBH4 KDjCyafjYdGtA== Message-ID: <93228d2f-0fc8-0c0e-f5ea-f55ed72da908@kernel.org> Date: Wed, 8 Mar 2023 13:15:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXTERNAL] Re: [PATCH v3 4/6] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Content-Language: en-US To: Md Danish Anwar , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Tero Kristo , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230306110934.2736465-1-danishanwar@ti.com> <20230306110934.2736465-5-danishanwar@ti.com> <2f039534-dd21-7361-0fcd-b91da1636a3a@kernel.org> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2023 11:23, Md Danish Anwar wrote: > Hi Roger, > > On 08/03/23 14:04, Roger Quadros wrote: >> Hi Danish, >> >> On 06/03/2023 13:09, MD Danish Anwar wrote: >>> From: Suman Anna >>> >>> The PRUSS CFG module is represented as a syscon node and is currently >>> managed by the PRUSS platform driver. Add easy accessor functions to set >>> GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable >>> to enable the PRUSS Ethernet usecase. These functions reuse the generic >>> pruss_cfg_update() API function. >>> >>> Signed-off-by: Suman Anna >>> Co-developed-by: Grzegorz Jaszczyk >>> Signed-off-by: Grzegorz Jaszczyk >>> Signed-off-by: Puranjay Mohan >>> --- >>> include/linux/remoteproc/pruss.h | 55 ++++++++++++++++++++++++++++++++ >>> 1 file changed, 55 insertions(+) >>> >>> diff --git a/include/linux/remoteproc/pruss.h b/include/linux/remoteproc/pruss.h >>> index d41bec448f06..7952f250301a 100644 >>> --- a/include/linux/remoteproc/pruss.h >>> +++ b/include/linux/remoteproc/pruss.h >>> @@ -240,4 +240,59 @@ static inline bool is_pru_rproc(struct device *dev) >>> return true; >>> } >>> >>> +/** >>> + * pruss_cfg_gpimode() - set the GPI mode of the PRU >>> + * @pruss: the pruss instance handle >>> + * @pru_id: id of the PRU core within the PRUSS >>> + * @mode: GPI mode to set >>> + * >>> + * Sets the GPI mode for a given PRU by programming the >>> + * corresponding PRUSS_CFG_GPCFGx register >>> + * >>> + * Return: 0 on success, or an error code otherwise >>> + */ >>> +static inline int pruss_cfg_gpimode(struct pruss *pruss, >>> + enum pruss_pru_id pru_id, >>> + enum pruss_gpi_mode mode) >>> +{ >>> + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) >>> + return -EINVAL; >>> + >> >> Should we check for invalid gpi mode and error out if so? >> > Sure we can check for invalid gpi mode. > > Does the below code snippet looks good to you? > > if(mode < PRUSS_GPI_MODE_DIRECT || mode > PRUSS_GPI_MODE_MII) How about? if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) > return -EINVAL; > >>> + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), >>> + PRUSS_GPCFG_PRU_GPI_MODE_MASK, >>> + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); >>> +} >>> + >>> +/** >>> + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events >>> + * @pruss: the pruss instance >>> + * @enable: enable/disable >>> + * >>> + * Enable/disable the MII RT Events for the PRUSS. >>> + * >>> + * Return: 0 on success, or an error code otherwise >>> + */ >>> +static inline int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) >>> +{ >>> + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; >>> + >>> + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, >>> + PRUSS_MII_RT_EVENT_EN, set); >>> +} >>> + >>> +/** >>> + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality >>> + * @pruss: the pruss instance >>> + * @enable: enable/disable >>> + * >>> + * Return: 0 on success, or an error code otherwise >>> + */ >>> +static inline int pruss_cfg_xfr_enable(struct pruss *pruss, bool enable) >>> +{ >>> + u32 set = enable ? PRUSS_SPP_XFER_SHIFT_EN : 0; >>> + >>> + return pruss_cfg_update(pruss, PRUSS_CFG_SPP, >>> + PRUSS_SPP_XFER_SHIFT_EN, set); >>> +} >>> + >>> #endif /* __LINUX_PRUSS_H */ >> cheers, -roger