From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] staging: r8188eu: Shorten calls chain of rtw_read8/16/32()
Date: Fri, 10 Sep 2021 17:19:58 +0200 [thread overview]
Message-ID: <9324065.O9NRuxeco7@localhost.localdomain> (raw)
In-Reply-To: <YTYgnrvwxNt4+CvR@kroah.com>
On Monday, September 6, 2021 4:07:26 PM CEST Greg Kroah-Hartman wrote:
> On Sun, Sep 05, 2021 at 12:00:47AM +0200, Fabio M. De Francesco wrote:
> > Shorten the calls chain of rtw_read8/16/32() down to the actual reads.
> > For this purpose unify the three usb_read8/16/32 into the new
> > usb_read(); make the latter parameterizable with 'size'; embed most of
> > the code of usbctrl_vendorreq() into usb_read() and use in it the new
> > usb_control_msg_recv() API of USB Core.
> >
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Co-developed-by: Pavel Skripkin <paskripkin@gmail.com>
> > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > [...]
> >
> > + while (++vendorreq_times <= MAX_USBCTRL_VENDORREQ_TIMES) {
> > + status = usb_control_msg_recv(udev, 0,
REALTEK_USB_VENQT_CMD_REQ,
> > +
REALTEK_USB_VENQT_READ, value,
> > +
REALTEK_USB_VENQT_CMD_IDX, io_buf,
> > + size,
RTW_USB_CONTROL_MSG_TIMEOUT,
> > + GFP_KERNEL);
> > + if (!status) { /* Success this control transfer. */
>
> Comments go on the next line.
>
> > + rtw_reset_continual_urb_error(dvobjpriv);
> > + memcpy(data, io_buf, size);
> > + } else { /* error cases */
>
> Again, next line for the comment.
>
> > + DBG_88E("reg 0x%x, usb %s %u fail, status:
%d vendorreq_times:%d\n",
> > + value, "read", size, status,
vendorreq_times);
>
> These should be removed eventually...
>
> > +
> > + if (status == (-ESHUTDOWN) || status == -
ENODEV) {
> > + adapt->bSurpriseRemoved = true;
>
> Odd, but ok...
I'm not so sure that it is OK. Please correct me if I'm wrong...
The calls chain from usb_control_msg_recv() seems to be the following:
usb_control_msg_recv/send()
-> usb_control_msg()
-> usb_internal_control_msg()
-> usb_start_wait_urb()
-> usb_submit_urb()
Each of the above functions could fail for different reasons and if so they
return the errors up to the first caller into "status". I can find no lines
of code where the above-mentioned functions set and return -ESHUTDOWN.
Unless I'm missing something obvious, "status" is a non-shared variable. The
variables that are assigned with errors in all five of the above-mentioned
functions are also local (non shared) variables.
To summarize: how could "status" be assigned -ESHUTDOWN? Is any point in the
chain that value assigned by a concurrent thread to a shared variable and
then returned up to the caller (i.e., usb_control_msg_recv())?
Since the code has this "if (status == (-ESHUTDOWN) || ...)" it expects that
sometimes it could be 'true', so I'm 100% sure that I can't see where my
argument is not valid... :(
Can someone please help me to understand this topic?
Thanks,
Fabio
>
> > [...]
next prev parent reply other threads:[~2021-09-10 15:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 22:00 [PATCH v3 0/3] staging: r8188eu: Shorten and simplify calls chain Fabio M. De Francesco
2021-09-04 22:00 ` [PATCH v3 1/3] staging: r8188eu: remove _io_ops structure Fabio M. De Francesco
2021-09-06 13:56 ` Greg Kroah-Hartman
2021-09-06 14:01 ` Pavel Skripkin
2021-09-06 14:08 ` Greg Kroah-Hartman
2021-09-06 17:19 ` Pavel Skripkin
2021-09-07 5:01 ` Greg Kroah-Hartman
2021-09-04 22:00 ` [PATCH v3 2/3] staging: r8188eu: Shorten calls chain of rtw_read8/16/32() Fabio M. De Francesco
2021-09-06 14:07 ` Greg Kroah-Hartman
2021-09-06 14:22 ` Pavel Skripkin
2021-09-09 7:53 ` Fabio M. De Francesco
2021-09-10 15:19 ` Fabio M. De Francesco [this message]
2021-09-10 19:05 ` Fabio M. De Francesco
2021-09-04 22:00 ` [PATCH v3 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() Fabio M. De Francesco
2021-09-07 10:10 ` David Laight
2021-09-07 10:17 ` Pavel Skripkin
2021-09-09 8:11 ` Fabio M. De Francesco
2021-09-09 8:21 ` David Laight
2021-09-09 8:31 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9324065.O9NRuxeco7@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).