From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: Colin King <colin.king@canonical.com>,
"qla2xxx-upstream@qlogic.com" <qla2xxx-upstream@qlogic.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer
Date: Mon, 9 Jan 2017 23:22:52 +0000 [thread overview]
Message-ID: <9325F928-2A19-448A-8C15-1641DF5BBDB0@cavium.com> (raw)
In-Reply-To: <20161229222038.29984-1-colin.king@canonical.com>
On 12/29/16, 2:20 PM, "Colin King" <colin.king@canonical.com> wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Rename the vendor_indentifer and hba_indentifer fields to correct spelling.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/qla2xxx/qla_def.h | 4 ++--
> drivers/scsi/qla2xxx/qla_gs.c | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>index f7df01b..ef699b6 100644
>--- a/drivers/scsi/qla2xxx/qla_def.h
>+++ b/drivers/scsi/qla2xxx/qla_def.h
>@@ -2247,7 +2247,7 @@ struct ct_fdmiv2_hba_attr {
> uint32_t num_ports;
> uint8_t fabric_name[WWN_SIZE];
> uint8_t bios_name[32];
>- uint8_t vendor_indentifer[8];
>+ uint8_t vendor_identifier[8];
> } a;
> };
>
>@@ -2422,7 +2422,7 @@ struct ct_sns_req {
> } rsnn_nn;
>
> struct {
>- uint8_t hba_indentifier[8];
>+ uint8_t hba_identifier[8];
> } ghat;
>
> struct {
>diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
>index 94e8a85..ee3df87 100644
>--- a/drivers/scsi/qla2xxx/qla_gs.c
>+++ b/drivers/scsi/qla2xxx/qla_gs.c
>@@ -1939,15 +1939,15 @@ qla2x00_fdmiv2_rhba(scsi_qla_host_t *vha)
> /* Vendor Identifier */
> eiter = entries + size;
> eiter->type = cpu_to_be16(FDMI_HBA_TYPE_VENDOR_IDENTIFIER);
>- snprintf(eiter->a.vendor_indentifer, sizeof(eiter->a.vendor_indentifer),
>+ snprintf(eiter->a.vendor_identifier, sizeof(eiter->a.vendor_identifier),
> "%s", "QLGC");
>- alen = strlen(eiter->a.vendor_indentifer);
>+ alen = strlen(eiter->a.vendor_identifier);
> alen += 4 - (alen & 3);
> eiter->len = cpu_to_be16(4 + alen);
> size += 4 + alen;
>
> ql_dbg(ql_dbg_disc, vha, 0x20b1,
>- "Vendor Identifier = %s.\n", eiter->a.vendor_indentifer);
>+ "Vendor Identifier = %s.\n", eiter->a.vendor_identifier);
>
> /* Update MS request size. */
> qla2x00_update_ms_fdmi_iocb(vha, size + 16);
>--
>2.10.2
Looks good
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
>
next prev parent reply other threads:[~2017-01-09 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 22:20 [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer Colin King
2017-01-09 23:22 ` Madhani, Himanshu [this message]
2017-01-10 4:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9325F928-2A19-448A-8C15-1641DF5BBDB0@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).