linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
	tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
	thierry.reding@gmail.com, perex@perex.cz
Cc: jonathanh@nvidia.com, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Mohan Kumar <mkumard@nvidia.com>,
	robh+dt@kernel.org
Subject: Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices
Date: Tue, 14 Dec 2021 09:15:44 +0300	[thread overview]
Message-ID: <93276b40-9ff8-f401-2624-04c0ff02c755@gmail.com> (raw)
In-Reply-To: <7230ad0b-2b04-4f1b-b616-b7d98789ded0@gmail.com>

14.12.2021 09:09, Dmitry Osipenko пишет:
> 14.12.2021 09:02, Sameer Pujar пишет:
>>
>>
>> On 12/8/2021 5:35 PM, Dmitry Osipenko wrote:
>>> 08.12.2021 08:22, Sameer Pujar пишет:
>>>>
>>>> On 12/7/2021 11:32 PM, Dmitry Osipenko wrote
>>>>> If display is already active, then shared power domain is already
>>>>> ungated.
>>>> If display is already active, then shared power domain is already
>>>> ungated. HDA reset is already applied during this ungate. In other
>>>> words, HDA would be reset as well when display ungates power-domain.
>>> Now, if you'll reload the HDA driver module while display is active,
>>> you'll get a different reset behaviour. HDA hardware will be reset on
>>> pre-T186, on T186+ it won't be reset.
>>
>> How the reset behavior is different? At this point when HDA driver is
>> loaded the HW is already reset during display ungate. What matters,
>> during HDA driver load, is whether the HW is in predictable state or not
>> and the answer is yes. So I am not sure what problem you are referring
>> to. Question is, if BPMP already ensures this, then why driver needs to
>> take care of it.
> 
> 1. Enable display
> 2. Play audio over HDMI
> 3. HDA hardware now is in dirty state
> 4. Reload HDA driver
> 5. In your case HDA is kept in dirty state, in my no
> 

The power domain is shared by display and HDA, is this correct?

If yes, then the shared power domain will be turned off only when all
its clients are turned off, i.e. both display and HDA simultaneously.

  reply	other threads:[~2021-12-14  6:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07  6:32 [PATCH 0/3] Fix Tegra194 HDA regression Sameer Pujar
2021-12-07  6:32 ` [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices Sameer Pujar
2021-12-07  8:16   ` Thierry Reding
2021-12-07  8:36     ` Takashi Iwai
2021-12-07  9:09       ` Sameer Pujar
2021-12-07 10:22   ` Dmitry Osipenko
2021-12-07 10:44     ` Dmitry Osipenko
2021-12-07 10:58       ` Dmitry Osipenko
2021-12-07 11:02         ` Jon Hunter
2021-12-07 11:57           ` Dmitry Osipenko
2021-12-07 15:07             ` Jon Hunter
2021-12-07 12:00     ` Sameer Pujar
2021-12-07 12:05       ` Dmitry Osipenko
2021-12-07 12:40         ` Sameer Pujar
2021-12-07 14:07           ` Dmitry Osipenko
2021-12-07 14:49             ` Sameer Pujar
2021-12-07 15:35               ` Dmitry Osipenko
2021-12-07 17:37                 ` Sameer Pujar
2021-12-07 18:02                   ` Dmitry Osipenko
2021-12-08  5:22                     ` Sameer Pujar
2021-12-08 12:05                       ` Dmitry Osipenko
2021-12-14  6:02                         ` Sameer Pujar
2021-12-14  6:09                           ` Dmitry Osipenko
2021-12-14  6:15                             ` Dmitry Osipenko [this message]
2021-12-14  7:22                             ` Sameer Pujar
2021-12-14 13:56                               ` Dmitry Osipenko
2021-12-14 14:29                                 ` Takashi Iwai
2021-12-14 15:34                                   ` Dmitry Osipenko
2021-12-20 10:32                                 ` Sameer Pujar
2021-12-07  6:32 ` [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets Sameer Pujar
2021-12-07  8:18   ` Thierry Reding
2021-12-07  9:27     ` Sameer Pujar
2021-12-07 10:14   ` Dmitry Osipenko
2021-12-07 11:04     ` Sameer Pujar
2021-12-07 12:02       ` Dmitry Osipenko
2021-12-07 12:22         ` Sameer Pujar
2021-12-07  6:32 ` [PATCH 3/3] arm64: tegra: Remove non existent Tegra194 reset Sameer Pujar
2021-12-07  8:04 ` [PATCH 0/3] Fix Tegra194 HDA regression Takashi Iwai
2021-12-07  8:21   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93276b40-9ff8-f401-2624-04c0ff02c755@gmail.com \
    --to=digetx@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkumard@nvidia.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=spujar@nvidia.com \
    --cc=stable@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).