From: <Claudiu.Beznea@microchip.com>
To: <lee.jones@linaro.org>
Cc: <alexandre.belloni@bootlin.com>, <bbrezillon@kernel.org>,
<airlied@linux.ie>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <Ludovic.Desroches@microchip.com>,
<daniel@ffwll.ch>, <sam@ravnborg.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/6] mfd: atmel-hlcdc: return in case of error
Date: Wed, 18 Dec 2019 10:02:36 +0000 [thread overview]
Message-ID: <9340342a-a908-d4f6-3293-8571a8d3e242@microchip.com> (raw)
In-Reply-To: <20191216162406.GQ2369@dell>
On 16.12.2019 18:24, Lee Jones wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, 13 Dec 2019, Claudiu Beznea wrote:
>
>> For HLCDC timing engine configurations bit ATMEL_HLCDC_SIP of
>> ATMEL_HLCDC_SR needs to be polled before applying new config. In case of
>> timeout there is no indicator about this, so, return in case of timeout
>> and also print a message about this.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>> drivers/mfd/atmel-hlcdc.c | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c
>> index 92bfcaa62ace..a1e46c87b956 100644
>> --- a/drivers/mfd/atmel-hlcdc.c
>> +++ b/drivers/mfd/atmel-hlcdc.c
>> @@ -40,10 +40,17 @@ static int regmap_atmel_hlcdc_reg_write(void *context, unsigned int reg,
>>
>> if (reg <= ATMEL_HLCDC_DIS) {
>> u32 status;
>> -
>> - readl_poll_timeout_atomic(hregmap->regs + ATMEL_HLCDC_SR,
>> - status, !(status & ATMEL_HLCDC_SIP),
>> - 1, 100);
>> + int ret;
>> +
>> + ret = readl_poll_timeout_atomic(hregmap->regs + ATMEL_HLCDC_SR,
>> + status,
>> + !(status & ATMEL_HLCDC_SIP),
>> + 1, 100);
>> + if (ret) {
>> + dev_err(hregmap->dev,
>> + "Timeout waiting for ATMEL_HLCDC_SIP\n");
>
> Nit: Just in case you have to rework this, placing register names in
> the kernel log isn't usually helpful. Can you swap it out for a more
> user friendly message?
Sure! I'll do a v3 for it.
Thank you,
Claudiu Beznea
>
> "Timed out waiting for ..."
>
> ... X status
> ... Y to update
> ... setting Z configuration
>
> Etc.
>
>> + return ret;
>> + }
>> }
>>
>> writel(val, hregmap->regs + reg);
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2019-12-18 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:04 [PATCH v2 0/6] fixes for atmel-hlcdc Claudiu Beznea
2019-12-13 15:04 ` [PATCH v2 1/6] drm: atmel-hlcdc: use double rate for pixel clock only if supported Claudiu Beznea
2019-12-13 15:04 ` [PATCH v2 2/6] drm: atmel-hlcdc: enable clock before configuring timing engine Claudiu Beznea
2019-12-13 15:04 ` [PATCH v2 3/6] mfd: atmel-hlcdc: add struct device member to struct atmel_hlcdc_regmap Claudiu Beznea
2019-12-16 16:17 ` Lee Jones
2019-12-13 15:04 ` [PATCH v2 4/6] mfd: atmel-hlcdc: return in case of error Claudiu Beznea
2019-12-16 16:22 ` Lee Jones
2019-12-16 16:24 ` Lee Jones
2019-12-18 10:02 ` Claudiu.Beznea [this message]
2019-12-13 15:04 ` [PATCH v2 5/6] drm: atmel-hlcdc: prefer a lower pixel-clock than requested Claudiu Beznea
2019-12-13 15:04 ` [PATCH v2 6/6] Revert "drm: atmel-hlcdc: enable sys_clk during initalization." Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9340342a-a908-d4f6-3293-8571a8d3e242@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).