From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Eric Tremblay <etremblay@distech-controls.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: gpio-fan: mark OF related data as maybe unused
Date: Sun, 12 Mar 2023 11:48:02 -0700 [thread overview]
Message-ID: <9343421e-d35d-8d99-1ea7-1f81e28fbabb@roeck-us.net> (raw)
In-Reply-To: <48b6689e-f045-5e24-ead7-f6da5b8fe454@linaro.org>
On 3/12/23 11:08, Krzysztof Kozlowski wrote:
> On 12/03/2023 19:06, Guenter Roeck wrote:
>> On Sat, Mar 11, 2023 at 12:16:09PM +0100, Krzysztof Kozlowski wrote:
>>> The driver can be compile tested with !CONFIG_OF making certain data
>>> unused:
>>>
>>> drivers/hwmon/gpio-fan.c:484:34: error: ‘of_gpio_fan_match’ defined but not used [-Werror=unused-const-variable=]
>>>
>>
>> How do you trigger that ? The driver depends on OF_GPIO which
>> in turn depends on OF. Arguably that means that of_match_ptr()
>> doesnot really make sense, but still I don't see how you can
>> trigger the above error message.
>
> I can drop of_match_ptr, it's indeed in many cases not needed.
>
> I just build x86_64 allyesconfig minus OF, with W=1.
>
x86_64 allyesconfig minus OF minus results in SENSORS_GPIO_FAN being
deselected (it doesn't show up in the configuration anymore at all
after "make olddefconfig").
$ make allyesconfig
$ grep SENSORS_GPIO_FAN .config
CONFIG_SENSORS_GPIO_FAN=y
$ sed -i -e 's/CONFIG_OF=y/# CONFIG_OF is not set/' .config
$ make olddefconfig
#
# configuration written to .config
#
$ grep SENSORS_GPIO_FAN .config
$
I suspect what you did is to disable CONFIG_OF, and then you built
the driver without realizing that is was deselected.
> Do you want to me to drop of_match_ptr?
>
Yes, sure, that makes more sense. The reason though is that the
driver depends on CONFIG_OF=y, not because of the build failure.
Thanks,
Guenter
next prev parent reply other threads:[~2023-03-12 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:16 [PATCH 1/2] hwmon: gpio-fan: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 11:16 ` [PATCH 2/2] hwmon: tmp512: " Krzysztof Kozlowski
2023-03-12 18:10 ` Guenter Roeck
2023-03-12 18:00 ` [PATCH 1/2] hwmon: gpio-fan: " Guenter Roeck
2023-03-12 18:06 ` Guenter Roeck
2023-03-12 18:08 ` Krzysztof Kozlowski
2023-03-12 18:48 ` Guenter Roeck [this message]
2023-03-12 19:32 ` Krzysztof Kozlowski
2023-03-12 21:03 ` Guenter Roeck
2023-03-12 21:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9343421e-d35d-8d99-1ea7-1f81e28fbabb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=etremblay@distech-controls.com \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).