From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC37C4361B for ; Fri, 18 Dec 2020 10:40:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 469AD23A62 for ; Fri, 18 Dec 2020 10:40:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733202AbgLRKkR convert rfc822-to-8bit (ORCPT ); Fri, 18 Dec 2020 05:40:17 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:53634 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbgLRKkR (ORCPT ); Fri, 18 Dec 2020 05:40:17 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-197-PIVC8sKqNfOkRnhW4ZbtOA-1; Fri, 18 Dec 2020 10:38:35 +0000 X-MC-Unique: PIVC8sKqNfOkRnhW4ZbtOA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 18 Dec 2020 10:38:35 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 18 Dec 2020 10:38:35 +0000 From: David Laight To: 'Joe Perches' , Daniel West , "gregkh@linuxfoundation.org" CC: "hverkuil-cisco@xs4all.nl" , "mchehab+huawei@kernel.org" , "christian.gromm@microchip.com" , "masahiroy@kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: most: video: fixed a parentheses coding style issue. Thread-Topic: [PATCH] staging: most: video: fixed a parentheses coding style issue. Thread-Index: AQHW1NDTd/J3KnGAs0yZSrCCE0TdLqn8mvVQgAAG7ICAAAdwsA== Date: Fri, 18 Dec 2020 10:38:35 +0000 Message-ID: <934cbebcb57a49fd8761cc8b3aaffbfa@AcuMS.aculab.com> References: <20201217234501.351725-1-daniel.west.dev@gmail.com> <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches > Sent: 18 December 2020 10:09 > On Fri, 2020-12-18 at 09:49 +0000, David Laight wrote: > > From: Joe Perches > > checkpatch probably shouldn't complain about lines that end in ( > > if they are function definitions. > > Opinons vary. > > Very few function declaration/definitions in the linux kernel use the > one line per argument style (gnu indent -bfde) > > type function( > type argument1, > type argument2, > ... > ) > { > ... > } > > It probably shouldn't be encouraged. The only excuse for anything like that is if there are comments for each parameter that are used to generate the interface documentation. Using that style for function calls just wastes vertical space. At least that doesn't happen in the kernel. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)