From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376FEC433DF for ; Mon, 24 Aug 2020 08:29:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13AE82075B for ; Mon, 24 Aug 2020 08:29:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="axj1fpma" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgHXI3N (ORCPT ); Mon, 24 Aug 2020 04:29:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbgHXI3J (ORCPT ); Mon, 24 Aug 2020 04:29:09 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C55C061574 for ; Mon, 24 Aug 2020 01:29:09 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id u128so4445447pfb.6 for ; Mon, 24 Aug 2020 01:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2K6WTwIMAPjI/mFWjHAehqUSAvXRAhIwddvFBN/4ox0=; b=axj1fpmaqcL2Qqo0AMtAeS6B0LKBjq2tPBvFPljiQrgASaCnXDIbJ4z7d4VjuQiTzO +jGzyVIOL6Xo0Zl8tgRb/6ANQAREAa1p3nMY8l+/wfXMzuUzZS8WJ8K4RVFzdGAPSOLt Cu25OPgCOpOV48fmgSwCU9iMxRvkGZ1QAOz50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2K6WTwIMAPjI/mFWjHAehqUSAvXRAhIwddvFBN/4ox0=; b=dx8SyO8pV+r3ceMKkG1LCxhaVeas/ibBs8SqPNSrh71863tDi4HbMNuN7NITqtAoUg jgjFnN5QBMdr9RAMS6flVa8QRvnhBk+5l9TL3OqdyJ+CVes7fFGr7ukLLjXcpGeQcRLr 4esDHJbD5WMxkzILn5qKU+TVAnkmfUpaO1soldyHCHjrYowc+5x6DepCcnXlQQ6h+msb mr3ljPEG4fj9QogXPBqmgt/zJEO/K9mDglB5UARQhtwKUnwTfTJuV36F64EiyzyZMGdJ 7ixqr51q3WkKBFe9AZsFc5Jj7x9Rru4FwyQ05P2UT20EMzBdF4jlcpTQvmUN1FRGEkSy 7rKA== X-Gm-Message-State: AOAM531XSHRSwfvsIcciXQZSqEPD4zsPmaaomcB+7Z36Wt8frdM+Hhsr hl3cbEHiKyKgW19HF2wGTt0N36wcWU1YukPTBUL2bdsyZr6U5x1BZB4pbwe9rEE4rACPnJSOFyG TMBpdiMFbzMqjp/EKtjKOwE8inK/PzX8COy/qvkM5hfGXdMbwLbYX8zartAvOrYCj9rgrAt7nNU b1afmNe4N+eX3yYS6g X-Google-Smtp-Source: ABdhPJxJpp2dbQYy+c7xEPbxjJsA+XavJY3DvvaeIZvSws19WA21Xd666HyNd8XbMZp3ek05KWmEJw== X-Received: by 2002:a63:2746:: with SMTP id n67mr2883670pgn.314.1598257748320; Mon, 24 Aug 2020 01:29:08 -0700 (PDT) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id m22sm9074959pja.36.2020.08.24.01.29.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 01:29:07 -0700 (PDT) Subject: Re: [PATCH v1] brcmfmac: increase F2 watermark for BCM4329 To: Dmitry Osipenko , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200823142004.21990-1-digetx@gmail.com> From: Arend Van Spriel Message-ID: <93536fd4-8abc-e167-a184-5a5e36d4205a@broadcom.com> Date: Mon, 24 Aug 2020 10:28:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200823142004.21990-1-digetx@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: > This patch fixes SDHCI CRC errors during of RX throughput testing on > BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the > checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark > value is borrowed from downstream BCMDHD driver and it's the same as the > value used for the BCM4339 chip, hence let's re-use it for BCM4329. one comment, but when fixed you can add my.... Reviewed-by: Arend van Spriel > Signed-off-by: Dmitry Osipenko > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > index 3c07d1bbe1c6..ac3ee93a2378 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -4278,6 +4278,7 @@ static void brcmf_sdio_firmware_callback(struct device *dev, int err, > brcmf_sdiod_writeb(sdiod, SBSDIO_FUNC1_MESBUSYCTRL, > CY_43012_MESBUSYCTRL, &err); > break; > + case SDIO_DEVICE_ID_BROADCOM_4329: > case SDIO_DEVICE_ID_BROADCOM_4339: > brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes for 4339\n", Maybe better to drop the chip id from the debug message. The chip id is printed elsewhere already so it does not add info here and could only cause confusion. Maybe you can also remove it from the 43455 message a bit below.