From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A15C2D0A3 for ; Tue, 3 Nov 2020 14:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70A04223C7 for ; Tue, 3 Nov 2020 14:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgKCOnU (ORCPT ); Tue, 3 Nov 2020 09:43:20 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:3033 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727742AbgKCOnR (ORCPT ); Tue, 3 Nov 2020 09:43:17 -0500 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 7F9E3D02944A3A90DE54; Tue, 3 Nov 2020 14:43:15 +0000 (GMT) Received: from [10.47.5.37] (10.47.5.37) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 3 Nov 2020 14:43:13 +0000 Subject: Re: [perf metricgroup] fcc9c5243c: perf-sanity-tests.Parse_and_process_metrics.fail To: Ian Rogers , kajoljain CC: kernel test robot , Jin Yao , Andi Kleen , Arnaldo Carvalho de Melo , Will Deacon , Mark Rutland , Jiri Olsa , Leo Yan , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Namhyung Kim , Mathieu Poirier , , LKML , Linux ARM , Joakim Zhang , , James Clark , , 0day robot , References: <1602152121-240367-10-git-send-email-john.garry@huawei.com> <20201018085031.GK11647@shao2-debian> <602e6bb8-a4ac-fae7-ed61-edf252e08d9a@huawei.com> <6d22bbdf-1a7c-1ba9-3c1a-88600178facf@linux.ibm.com> From: John Garry Message-ID: <935893a3-297d-c6ed-524b-e50e5d5a0d54@huawei.com> Date: Tue, 3 Nov 2020 14:43:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.5.37] X-ClientProxiedBy: lhreml754-chm.china.huawei.com (10.201.108.204) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/10/2020 17:53, Ian Rogers wrote: >>> Thanks for taking a look John. If you want help you can send the >>> output of "perf test 67 -vvv" to me. It is possible Broadwell has >>> similar glitches in the json to Skylake. I tested the original test on >>> server parts as I can access them as cloud machines. >>> >>>> I will have a look, but I was hoping that Ian would have a proper fix >>>> for this on top of ("perf metricgroup: Fix uncore metric expressions"), >>>> which now looks to be merged. >>> I still have these changes to look at in my inbox but I'm assuming >>> they're good:-) Sorry for not getting to them, but it's good they are >>> merged. >> Hi Ian, >> Checked in upstream kernel with your fix patch, in powerpc also test case 67 is passing. >> But I am getting issue in test 10 for powerpc >> >> [command]# ./perf test 10 >> 10: PMU events : >> 10.1: PMU event table sanity : Ok >> 10.2: PMU event map aliases : Ok >> 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) >> 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED! >> >> Was debugging it, issue is with commit e1c92a7fbbc5 perf tests: Add another metric parsing test. >> >> So, there we are passing different runtime parameter value in "expr__find_other and expr__parse" >> in function `metric_parse_fake`. I believe we need to send same value. >> I will send fix patch for the same. Just wondering, was a patch ever submitted for this? Something still broken? I can't see any recent relevant changes to tests/pmu-events.c Thanks, John