From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754707AbdKINWg (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 08:22:36 -0500
Received: from mout.web.de ([212.227.15.14]:53280 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753227AbdKINWe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 08:22:34 -0500
Subject: Re: bq2415x_charger: Use common error handling code in
 bq2415x_timer_work()
To: =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali.rohar@gmail.com>,
        linux-pm@vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <48b34d35-8c41-d25b-0cb7-6257b37c5a44@users.sourceforge.net>
 <20171109120842.GA28552@atrey.karlin.mff.cuni.cz>
 <d680ca7e-9806-1f39-80da-58fa7239a31c@users.sourceforge.net>
 <20171109131433.x7xuh4bqvqm72wb5@pali>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <935e992c-e5ee-841b-c42a-4a7bf891d984@users.sourceforge.net>
Date: Thu, 9 Nov 2017 14:22:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171109131433.x7xuh4bqvqm72wb5@pali>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:1JQ/6matJLP8HloVyAjbnQAZVLPWZjEJv+mgqv31rN+w/hPq0NL
 sdj09ztU7G4VH7kZ2/pXTJqTKgYJD7K9lkwGydhQ5JnA+R4jXd+W2Rqspp1Ijrm9we5ip7U
 U8FgbvbUcAL38U7RtSoebHzcuZBlHj+Dqs1ugb5r0K5EYSRHvwV27Si2vvIrk8FpH5S1lJf
 s54ipYqDYvvALX9h9GpFw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:xJb6qJfTC6c=:pFNP50KCs4kCABNaNCyfNN
 uISUynsFOIT6afd7H/Qj460LILq9y+MXb8hBn55Nh5d0Jc0irwD8e9+1bs16Qg02DYzRDF21E
 yhtmnN8+qQDuBa69s+P1LmlZH+4K0XRHt/AdArWn3n6EFtlCL7oLgavmIVK64QWMF6Ks0nROz
 QFqGlFUWbGtBGApDUsKbxwZt2aOooTYF90THARz0IYQ3IjcBjFp28zUWUQMBdUU8K/Eigq+kL
 IeczmkT+QQQXhpfG62xbday/bDwgzExnUXu/M53z2+9HXvigNuinZNUQkmdS0H+DlNmWovV+F
 rSsYiflZQ9CuB5wNb2LHWmVOPIXx/x+nTJoAVpUjKQyqYjd9SOzVmY0czxThgYbv/W5HQA0tI
 oRClqqeFe7Mw597xpxCK0mdizkkfhoUAP3Zsv57wjEMMkty0G2Ib9mjIOyhPbRTg0okNVi+yL
 vdMpCwlVRt5cP0SVxYaQ6PdqBWRuqCI+3cROyCkXSaydgh7VsDtABAmfW+b9pbxpZsfQWKMbD
 JCVq4G9Tc57Kf4EZIe1Th/8VT3nYOzvbsLorxNj1UUtHxEdDSFs4jp/Vvd1zOzr0JEQG+rFOl
 FBvHHbceAoBOX/1yD2k2g7i5erzAPEYlyukNX9UNfJb9G4xavdUi0u0ymOQFJWLvEfADmqaGZ
 a3/Hn+P1iE/EZljXITJmQfVCwjztF4HH0KxUH30v0kt3TusALCCIAHs84oM9yor/UuIuSv6YI
 6JpTfhYaSpei7pmH4tcc2u7zAKT44Ca7NP5hMPeFzQ25RV5ExuEyn163fPYrkS2zyp1pkb+ka
 87uTGikagVMYLfN4HEB3AaK9sJtGwEW7i1J4WT5EGn7Fuaqwmw=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Which information (or wording) would you find more appropriate
>> at these places?
> 
> Hi! Basically dropping your patch and instead of the "Unknown error"
> return to user reason why BQ2415X_BOOST_MODE_STATUS or
> BQ2415X_FAULT_STATUS commands failed. Or at least instead of the
> "Unknown error" write "Unknown error during BQ2415X_FAULT_STATUS".

Can the error description become better?

Regards,
Markus