From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Yunsheng Lin <linyunsheng@huawei.com>,
davem@davemloft.net, kuba@kernel.org
Cc: brouer@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hkallweit1@gmail.com
Subject: Re: [PATCH net-next v2 1/2] page_pool: use relaxed atomic for release side accounting
Date: Fri, 20 Aug 2021 09:12:29 +0200 [thread overview]
Message-ID: <9363880e-4ed2-5acd-87da-d669b68d0134@redhat.com> (raw)
In-Reply-To: <1629442611-61547-2-git-send-email-linyunsheng@huawei.com>
On 20/08/2021 08.56, Yunsheng Lin wrote:
> There is no need to synchronize the account updating, so
> use the relaxed atomic to avoid some memory barrier in the
> data path.
>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
LGTM
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
> net/core/page_pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index e140905..1a69784 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -370,7 +370,7 @@ void page_pool_release_page(struct page_pool *pool, struct page *page)
> /* This may be the last page returned, releasing the pool, so
> * it is not safe to reference pool afterwards.
> */
> - count = atomic_inc_return(&pool->pages_state_release_cnt);
> + count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt);
> trace_page_pool_state_release(pool, page, count);
> }
> EXPORT_SYMBOL(page_pool_release_page);
>
next prev parent reply other threads:[~2021-08-20 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:56 [PATCH net-next v2 0/2] Some minor optimization for page pool Yunsheng Lin
2021-08-20 6:56 ` [PATCH net-next v2 1/2] page_pool: use relaxed atomic for release side accounting Yunsheng Lin
2021-08-20 7:12 ` Jesper Dangaard Brouer [this message]
2021-08-20 6:56 ` [PATCH net-next v2 2/2] page_pool: optimize the cpu sync operation when DMA mapping Yunsheng Lin
2021-08-20 9:39 ` Ilias Apalodimas
2021-08-23 3:56 ` Yunsheng Lin
2021-08-23 12:42 ` Ilias Apalodimas
2021-08-24 7:00 ` Yunsheng Lin
2021-08-24 9:04 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9363880e-4ed2-5acd-87da-d669b68d0134@redhat.com \
--to=jbrouer@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).