From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21979C43460 for ; Thu, 22 Apr 2021 01:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEC2561430 for ; Thu, 22 Apr 2021 01:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbhDVBvX (ORCPT ); Wed, 21 Apr 2021 21:51:23 -0400 Received: from mail-mw2nam12on2075.outbound.protection.outlook.com ([40.107.244.75]:58880 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229502AbhDVBvV (ORCPT ); Wed, 21 Apr 2021 21:51:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMdZbhkupS5yVY9UmNxMXHqjkAjIgZbZQBYcbAtrcqItjxjeUNNUjGort36etJ1g/re69CF883A8STiN2Lti4vc77boh8brbUNoQGzVZslItyHvyMtgJlZR6aCb3y/cfpPVf+qc58ceca9J7KPXJ6LtequCUvd/b7gfv40+mHpX/WtLc/bf4tzSU/gA56rYug7sK7H72ZG5p+9Jo1jbAXm+d9Ievrkp/94rP8uPvgrVNUBaUXGkI5I9myk7F8T28jHJIF4FRqJGiOy2Q/fKREgLL5SYdc0f0JcLdaavSxshP39gi+TKRiiDDLe7XAkUva+iOCZb4voS8snKB3tyOmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K3LKgF5TatyPwgXroPUddvrom6DALDkItnS+S+A530E=; b=audkX26sXBg7YOlqcfBC9DnVTI7wuvHwmayjXrxdkFpRdrofmyGYiCx6oOmBonO1aur04wcBkLwWVsw3JGMMJfza6IL0VTgwDqhtls5RgMDi72Ya+0fDX9MXCO7pJHxdLr2PRlzObH5/FclmYBvdkDb3QX2ttRQjZcqvBtfRVtetT4ucbD1jB4OtqEIMx0RSs+tRtLywg1zwtlpR2rVq7blAlw0rIgTiii83J/129i4p0oc/cFCBxzQFrMWfPQjN8eBd0xmASMgj6ztp9A/FvV4F8z34CR5MYHRv2W0nZYNgk4JrcMqfEfYBasjpL1oILnDMGeWhrKyuuRhrlDOSvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K3LKgF5TatyPwgXroPUddvrom6DALDkItnS+S+A530E=; b=SMC8tp/AcvT6IqMOGHc3Qy4waDiA+vkgZyr5MGxEX+zBKF0pPdnmmJu+Fkpq5otSM3kZmV4mmkZE+AQ3s/eMysELT1x44FroovPLZzdzgDsjx0djWafrv6Zm1DjfB1CA8AC88acd8rAV4fjG4nX8x2B/CoOYf2DC7qHnLd2O+HbQfR904qnfPhRHrAIZDH2ajAa/V0Z/nYTpPQgDzFnntISR6JMHJJgCMW0J+AQ5DxbOsPJvcNIIf5FyxTEGfpydG+jgisL3N5JZ+pZqXOXKqiWkAu/VB0PXs4gWnO8qOQgmTBqSxunBkjMLt7GxVe+SpajRlSF273BYd9dZzKaaFw== Received: from MW4PR04CA0127.namprd04.prod.outlook.com (2603:10b6:303:84::12) by MN2PR12MB4406.namprd12.prod.outlook.com (2603:10b6:208:268::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Thu, 22 Apr 2021 01:50:46 +0000 Received: from CO1NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:303:84:cafe::2) by MW4PR04CA0127.outlook.office365.com (2603:10b6:303:84::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Thu, 22 Apr 2021 01:50:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT049.mail.protection.outlook.com (10.13.175.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4065.21 via Frontend Transport; Thu, 22 Apr 2021 01:50:45 +0000 Received: from [10.19.101.193] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Apr 2021 01:50:43 +0000 Subject: Re: [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused To: Arnd Bergmann , Kishon Vijay Abraham I , Vinod Koul , Thierry Reding , Jonathan Hunter CC: Arnd Bergmann , Chunfeng Yun , Marc Zyngier , Rikard Falkeborn , , , References: <20210421135613.3560777-1-arnd@kernel.org> X-Nvconfidentiality: public From: JC Kuo Organization: NVIDIA Message-ID: <937252ad-d3f0-ff29-8e3d-1267d46202b0@nvidia.com> Date: Thu, 22 Apr 2021 09:50:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210421135613.3560777-1-arnd@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1932999-e331-4a09-7bae-08d905310bc9 X-MS-TrafficTypeDiagnostic: MN2PR12MB4406: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q3m6gmiK0K9Af7bBEECnjgTXVd2lYXy7iPUeJEl9yydNeYLg36Y8IXjua5T/9v6rWDoBdUkTWyNFtZCH8IWhTzxRWt2Jf8tbLWtCJ3NVahWBJI6lvK5UTtTAGds1laoVydhPNFN1I+7wjSagfD4WLYYXjbnG4S1ancbqhZ7mbvEjhlGxOMbS14vodGriH7D0Q1OlkOVdCCulPkjOWBgLikHeGI0abFR+jXBAzxucz9veig9Pv+HTX1V5BPp8kWhbCoQixqBZKTxDkcQjTmhjzXRJf3SIsG/ahtHFl9GM1px9ySpydyu12qCZDHV4QANieiU0iuiYjX9/9Q8VX7HwkjR580bPG8q+g7AbOENQ5EQMqS4S9QobkYC4wF5XdognqMlgAIwwb9nNJHyT5dphctH3BFgKKpM/owfznHvpvm9jWxBSFk+SqBP9XJxrp44fNlME3vuLqGYJUogyqkdT7aEsEMWS1cwB8urzK4Bke26ov5nn2FMBqxy0vlUHiCgvUa0ngNMFJ+SwYvD1JUukCyQLKYVVofHsjj8wd24b9HD8grkswoxAN7p69Ni1N0MpR35YjqKR0VXg0zE0Pqlegt8ry/wC8EAARqHt/73Rg6cZ5fvL8iyR8bloqHO7u6ohY4EvNUSLiaTMC7WSnm7X+BrRylekY5AkVOfvmdzeSQ6KMBpLizLq8pgZfnWUW0Dc X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(36840700001)(46966006)(426003)(31686004)(5660300002)(83380400001)(82740400003)(7636003)(316002)(6636002)(36860700001)(86362001)(186003)(31696002)(4326008)(82310400003)(47076005)(2906002)(26005)(2616005)(336012)(356005)(70206006)(36916002)(54906003)(478600001)(70586007)(7416002)(8676002)(16576012)(110136005)(36756003)(36906005)(16526019)(53546011)(8936002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2021 01:50:45.7816 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c1932999-e331-4a09-7bae-08d905310bc9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4406 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thanks for the fix. Reviewed-by: JC Kuo On 4/21/21 9:56 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > Depending on the configuration, there are no references to these > two helpers: > > drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function] > 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function] > > Mark them as __maybe_unused to shut up the warnings without adding > fragile #ifdefs. > > Fixes: b8bb3d9c9b74 ("phy: tegra: xusb: Add sleepwalk and suspend/resume") > Signed-off-by: Arnd Bergmann > --- > drivers/phy/tegra/xusb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c > index 0aadac678191..963de5913e50 100644 > --- a/drivers/phy/tegra/xusb.c > +++ b/drivers/phy/tegra/xusb.c > @@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) > return err; > } > > -static int tegra_xusb_padctl_suspend_noirq(struct device *dev) > +static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev) > { > struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev); > > @@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev) > return 0; > } > > -static int tegra_xusb_padctl_resume_noirq(struct device *dev) > +static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev) > { > struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev); > >